Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: ui/aura/mus/client_surface_embedder.cc

Issue 2616403003: Replacing SurfaceReferenceBase and SequenceSurfaceReference with Closures (Closed)
Patch Set: build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/surface_reference_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/mus/client_surface_embedder.cc
diff --git a/ui/aura/mus/client_surface_embedder.cc b/ui/aura/mus/client_surface_embedder.cc
index 53bc4f101160c5f60008ae8cdcf95e51d1e0ac14..e620e03790cfd1c41e2587d2825bd07339d40b91 100644
--- a/ui/aura/mus/client_surface_embedder.cc
+++ b/ui/aura/mus/client_surface_embedder.cc
@@ -12,10 +12,10 @@ namespace {
// TODO(mfomitchev, samans): Remove these stub classes once the SurfaceReference
// work is complete.
-class StubSurfaceReference : public cc::SurfaceReferenceBase {
+class StubSurfaceReference : public cc::ScopedSurfaceReferenceBase {
Fady Samuel 2017/01/10 03:05:29 I just noticed this doesn't actually do anything?
public:
StubSurfaceReference(scoped_refptr<const cc::SurfaceReferenceFactory> factory)
- : cc::SurfaceReferenceBase(factory) {}
+ : cc::ScopedSurfaceReferenceBase(factory) {}
~StubSurfaceReference() override { Destroy(); }
@@ -28,7 +28,7 @@ class StubSurfaceReferenceFactory : public cc::SurfaceReferenceFactory {
StubSurfaceReferenceFactory() = default;
// cc::SurfaceReferenceFactory:
- std::unique_ptr<cc::SurfaceReferenceBase> CreateReference(
+ std::unique_ptr<cc::ScopedSurfaceReferenceBase> CreateReference(
cc::SurfaceReferenceOwner* owner,
const cc::SurfaceId& surface_id) const override {
return base::MakeUnique<StubSurfaceReference>(make_scoped_refptr(this));
@@ -39,7 +39,8 @@ class StubSurfaceReferenceFactory : public cc::SurfaceReferenceFactory {
private:
// cc::SurfaceReferenceFactory:
- void DestroyReference(cc::SurfaceReferenceBase* surface_ref) const override {}
+ void DestroyReference(
+ cc::ScopedSurfaceReferenceBase* surface_ref) const override {}
DISALLOW_COPY_AND_ASSIGN(StubSurfaceReferenceFactory);
};
« no previous file with comments | « cc/surfaces/surface_reference_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698