Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: cc/surfaces/sequence_surface_reference_factory.h

Issue 2616403003: Replacing SurfaceReferenceBase and SequenceSurfaceReference with Closures (Closed)
Patch Set: c Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/sequence_surface_reference_factory.h
diff --git a/cc/surfaces/sequence_surface_reference_factory.h b/cc/surfaces/sequence_surface_reference_factory.h
index ff0e9e3ef68a72ec1e0376bdaa26f9eeadb07122..a17fd79c8e417bc900ff4196ef40ee58cba3bca7 100644
--- a/cc/surfaces/sequence_surface_reference_factory.h
+++ b/cc/surfaces/sequence_surface_reference_factory.h
@@ -5,23 +5,20 @@
#ifndef CC_SURFACES_SEQUENCE_SURFACE_REFERENCE_FACTORY_H_
#define CC_SURFACES_SEQUENCE_SURFACE_REFERENCE_FACTORY_H_
-#include "cc/output/compositor_frame_metadata.h"
-#include "cc/surfaces/surface_reference_base.h"
#include "cc/surfaces/surface_reference_factory.h"
+#include "cc/surfaces/surface_sequence.h"
#include "cc/surfaces/surfaces_export.h"
namespace cc {
-// A surface reference factory that generates references which internally
-// use SurfaceSequence.
+// A surface reference factory that uses SurfaceSequence.
class CC_SURFACES_EXPORT SequenceSurfaceReferenceFactory
: public NON_EXPORTED_BASE(SurfaceReferenceFactory) {
public:
SequenceSurfaceReferenceFactory() = default;
- std::unique_ptr<SurfaceReferenceBase> CreateReference(
- SurfaceReferenceOwner* owner,
- const SurfaceId& surface_id) const override;
+ base::Closure CreateReference(SurfaceReferenceOwner* owner,
danakj 2017/01/10 21:12:06 // SurfaceReferenceFactory implementation.
Saman Sami 2017/01/10 21:56:14 Done.
+ const SurfaceId& surface_id) const override;
protected:
~SequenceSurfaceReferenceFactory() override = default;
@@ -31,9 +28,6 @@ class CC_SURFACES_EXPORT SequenceSurfaceReferenceFactory
const SurfaceSequence& sequence) const = 0;
virtual void SatisfySequence(const SurfaceSequence& sequence) const = 0;
- // SurfaceReferenceFactory implementation:
- void DestroyReference(SurfaceReferenceBase* surface_ref) const override;
-
DISALLOW_COPY_AND_ASSIGN(SequenceSurfaceReferenceFactory);
};

Powered by Google App Engine
This is Rietveld 408576698