Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: cc/layers/surface_layer.cc

Issue 2616403003: Replacing SurfaceReferenceBase and SequenceSurfaceReference with Closures (Closed)
Patch Set: build Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/surface_layer.h" 5 #include "cc/layers/surface_layer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
11 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "base/trace_event/trace_event.h" 12 #include "base/trace_event/trace_event.h"
13 #include "cc/layers/surface_layer_impl.h" 13 #include "cc/layers/surface_layer_impl.h"
14 #include "cc/output/swap_promise.h" 14 #include "cc/output/swap_promise.h"
15 #include "cc/surfaces/surface_sequence_generator.h" 15 #include "cc/surfaces/surface_sequence_generator.h"
16 #include "cc/trees/layer_tree_host.h" 16 #include "cc/trees/layer_tree_host.h"
17 #include "cc/trees/swap_promise_manager.h" 17 #include "cc/trees/swap_promise_manager.h"
18 18
19 namespace cc { 19 namespace cc {
20 20
21 class SatisfySwapPromise : public SwapPromise { 21 class SatisfySwapPromise : public SwapPromise {
22 public: 22 public:
23 SatisfySwapPromise( 23 SatisfySwapPromise(
24 std::unique_ptr<SurfaceReferenceBase> surface_ref, 24 std::unique_ptr<ScopedSurfaceReferenceBase> surface_ref,
25 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner) 25 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner)
26 : surface_ref_(std::move(surface_ref)), 26 : surface_ref_(std::move(surface_ref)),
27 main_task_runner_(std::move(main_task_runner)) {} 27 main_task_runner_(std::move(main_task_runner)) {}
28 28
29 ~SatisfySwapPromise() override {} 29 ~SatisfySwapPromise() override {}
30 30
31 private: 31 private:
32 void DidActivate() override {} 32 void DidActivate() override {}
33 33
34 void WillSwap(CompositorFrameMetadata* metadata) override {} 34 void WillSwap(CompositorFrameMetadata* metadata) override {}
35 35
36 void DidSwap() override { 36 void DidSwap() override {
37 main_task_runner_->DeleteSoon(FROM_HERE, surface_ref_.release()); 37 main_task_runner_->DeleteSoon(FROM_HERE, surface_ref_.release());
38 } 38 }
39 39
40 DidNotSwapAction DidNotSwap(DidNotSwapReason reason) override { 40 DidNotSwapAction DidNotSwap(DidNotSwapReason reason) override {
41 main_task_runner_->DeleteSoon(FROM_HERE, surface_ref_.release()); 41 main_task_runner_->DeleteSoon(FROM_HERE, surface_ref_.release());
42 return DidNotSwapAction::BREAK_PROMISE; 42 return DidNotSwapAction::BREAK_PROMISE;
43 } 43 }
44 44
45 int64_t TraceId() const override { return 0; } 45 int64_t TraceId() const override { return 0; }
46 46
47 std::unique_ptr<SurfaceReferenceBase> surface_ref_; 47 std::unique_ptr<ScopedSurfaceReferenceBase> surface_ref_;
48 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_; 48 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
49 49
50 DISALLOW_COPY_AND_ASSIGN(SatisfySwapPromise); 50 DISALLOW_COPY_AND_ASSIGN(SatisfySwapPromise);
51 }; 51 };
52 52
53 scoped_refptr<SurfaceLayer> SurfaceLayer::Create( 53 scoped_refptr<SurfaceLayer> SurfaceLayer::Create(
54 scoped_refptr<SurfaceReferenceFactory> ref_factory) { 54 scoped_refptr<SurfaceReferenceFactory> ref_factory) {
55 return make_scoped_refptr(new SurfaceLayer(std::move(ref_factory))); 55 return make_scoped_refptr(new SurfaceLayer(std::move(ref_factory)));
56 } 56 }
57 57
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 void SurfaceLayer::RemoveCurrentReference() { 108 void SurfaceLayer::RemoveCurrentReference() {
109 if (!current_ref_) 109 if (!current_ref_)
110 return; 110 return;
111 auto swap_promise = base::MakeUnique<SatisfySwapPromise>( 111 auto swap_promise = base::MakeUnique<SatisfySwapPromise>(
112 std::move(current_ref_), base::ThreadTaskRunnerHandle::Get()); 112 std::move(current_ref_), base::ThreadTaskRunnerHandle::Get());
113 layer_tree_host()->GetSwapPromiseManager()->QueueSwapPromise( 113 layer_tree_host()->GetSwapPromiseManager()->QueueSwapPromise(
114 std::move(swap_promise)); 114 std::move(swap_promise));
115 } 115 }
116 116
117 } // namespace cc 117 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698