Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: cc/trees/property_tree.cc

Issue 2616353003: Clarify property tree id-to-index map names. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/property_tree.cc
diff --git a/cc/trees/property_tree.cc b/cc/trees/property_tree.cc
index 1b0b5954a547fef475042fc8985caa199747098d..0db7ad0f5cdd9a94793262227476ad888274d718 100644
--- a/cc/trees/property_tree.cc
+++ b/cc/trees/property_tree.cc
@@ -1532,10 +1532,11 @@ bool PropertyTrees::operator==(const PropertyTrees& other) const {
return transform_tree == other.transform_tree &&
effect_tree == other.effect_tree && clip_tree == other.clip_tree &&
scroll_tree == other.scroll_tree &&
- transform_id_to_index_map == other.transform_id_to_index_map &&
- effect_id_to_index_map == other.effect_id_to_index_map &&
- clip_id_to_index_map == other.clip_id_to_index_map &&
- scroll_id_to_index_map == other.scroll_id_to_index_map &&
+ layer_id_to_transform_node_index ==
+ other.layer_id_to_transform_node_index &&
+ layer_id_to_effect_node_index == other.layer_id_to_effect_node_index &&
+ layer_id_to_clip_node_index == other.layer_id_to_clip_node_index &&
+ layer_id_to_scroll_node_index == other.layer_id_to_scroll_node_index &&
always_use_active_tree_opacity_effect_ids ==
other.always_use_active_tree_opacity_effect_ids &&
needs_rebuild == other.needs_rebuild && changed == other.changed &&
@@ -1551,12 +1552,12 @@ PropertyTrees& PropertyTrees::operator=(const PropertyTrees& from) {
effect_tree = from.effect_tree;
clip_tree = from.clip_tree;
scroll_tree = from.scroll_tree;
- transform_id_to_index_map = from.transform_id_to_index_map;
- effect_id_to_index_map = from.effect_id_to_index_map;
+ layer_id_to_transform_node_index = from.layer_id_to_transform_node_index;
+ layer_id_to_effect_node_index = from.layer_id_to_effect_node_index;
always_use_active_tree_opacity_effect_ids =
from.always_use_active_tree_opacity_effect_ids;
- clip_id_to_index_map = from.clip_id_to_index_map;
- scroll_id_to_index_map = from.scroll_id_to_index_map;
+ layer_id_to_clip_node_index = from.layer_id_to_clip_node_index;
+ layer_id_to_scroll_node_index = from.layer_id_to_scroll_node_index;
needs_rebuild = from.needs_rebuild;
changed = from.changed;
full_tree_damaged = from.full_tree_damaged;
@@ -1583,10 +1584,10 @@ void PropertyTrees::clear() {
clip_tree.clear();
effect_tree.clear();
scroll_tree.clear();
- transform_id_to_index_map.clear();
- effect_id_to_index_map.clear();
- clip_id_to_index_map.clear();
- scroll_id_to_index_map.clear();
+ layer_id_to_transform_node_index.clear();
+ layer_id_to_effect_node_index.clear();
+ layer_id_to_clip_node_index.clear();
+ layer_id_to_scroll_node_index.clear();
always_use_active_tree_opacity_effect_ids.clear();
needs_rebuild = true;
@@ -1640,12 +1641,13 @@ void PropertyTrees::SetInnerViewportScrollBoundsDelta(
void PropertyTrees::PushOpacityIfNeeded(PropertyTrees* target_tree) {
for (int id : target_tree->always_use_active_tree_opacity_effect_ids) {
- if (effect_id_to_index_map.find(id) == effect_id_to_index_map.end())
+ if (layer_id_to_effect_node_index.find(id) ==
+ layer_id_to_effect_node_index.end())
continue;
EffectNode* source_effect_node =
- effect_tree.Node(effect_id_to_index_map[id]);
- EffectNode* target_effect_node =
- target_tree->effect_tree.Node(target_tree->effect_id_to_index_map[id]);
+ effect_tree.Node(layer_id_to_effect_node_index[id]);
+ EffectNode* target_effect_node = target_tree->effect_tree.Node(
+ target_tree->layer_id_to_effect_node_index[id]);
float source_opacity = source_effect_node->opacity;
float target_opacity = target_effect_node->opacity;
if (source_opacity == target_opacity)
@@ -1656,26 +1658,26 @@ void PropertyTrees::PushOpacityIfNeeded(PropertyTrees* target_tree) {
}
void PropertyTrees::RemoveIdFromIdToIndexMaps(int id) {
- transform_id_to_index_map.erase(id);
- effect_id_to_index_map.erase(id);
- clip_id_to_index_map.erase(id);
- scroll_id_to_index_map.erase(id);
+ layer_id_to_transform_node_index.erase(id);
+ layer_id_to_effect_node_index.erase(id);
+ layer_id_to_clip_node_index.erase(id);
+ layer_id_to_scroll_node_index.erase(id);
}
bool PropertyTrees::IsInIdToIndexMap(TreeType tree_type, int id) {
std::unordered_map<int, int>* id_to_index_map = nullptr;
switch (tree_type) {
case TRANSFORM:
- id_to_index_map = &transform_id_to_index_map;
+ id_to_index_map = &layer_id_to_transform_node_index;
break;
case EFFECT:
- id_to_index_map = &effect_id_to_index_map;
+ id_to_index_map = &layer_id_to_effect_node_index;
break;
case CLIP:
- id_to_index_map = &clip_id_to_index_map;
+ id_to_index_map = &layer_id_to_clip_node_index;
break;
case SCROLL:
- id_to_index_map = &scroll_id_to_index_map;
+ id_to_index_map = &layer_id_to_scroll_node_index;
break;
}
return id_to_index_map->find(id) != id_to_index_map->end();

Powered by Google App Engine
This is Rietveld 408576698