Update some documentation for CertVerifyResult::verified_cert

net/cert/cert_verify_proc.h

Index: net/cert/cert_verify_proc.h
diff --git a/net/cert/cert_verify_proc.h b/net/cert/cert_verify_proc.h
index 5befe2418fe25fdabf233521fb2cbcd7ea9dd5be..70b64a3db8c52fa3f5e5b032274d0c103cd992d3 100644
--- a/net/cert/cert_verify_proc.h
+++ b/net/cert/cert_verify_proc.h
@@ -91,7 +91,12 @@ class NET_EXPORT CertVerifyProc
   // Performs the actual verification using the desired underlying
   // cryptographic library. On entry, |verify_result->verified_cert|
   // is set to |cert|, the unverified chain. If no chain is built, the
-  // value must be left untouched.
+  // value must be left untouched. On entry, |verify_result| is in a
+  // default-initialized state.
+  //
+  // Implementations of VerifyInternal() are responsible for filling in all
+  // applicable fields of |verify_result| EXCEPT for |ocsp_result|, which
+  // will be filled in by Verify().

[Ryan Sleevi, 2017/01/09 23:20:14]

Note quite true here: 

|verify_result| is explicitly initialized to set |verified_cert|

The contract might be better specified:

On entry, |verify_result| will be default-initialized as a successful
validation, with |verify_result->verified_cert| set to |cert|. Implementations
are expected to fill in all applicable fields, excluding |ocsp_result|, which
will be filled in by |Verify()|.  If an error code is returned,
|verify_result->cert_status| should be non-zero, indicating an error occurred.
On success, net::OK should be returned, with |verify_result| updated to reflect
the successfully verified chain.

IDK, WDYT?

[eroman, 2017/01/09 23:33:12]

Done.

   virtual int VerifyInternal(X509Certificate* cert,
                              const std::string& hostname,
                              const std::string& ocsp_response,