Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 261633006: Fix a findbugs error in content/browser/ViewportTest.java. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jam, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org
Visibility:
Public.

Description

Fix a findbugs error in content/browser/ViewportTest.java. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ViewportTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-04-30 20:44:44 UTC) #1
Yaron
lgtm
6 years, 7 months ago (2014-04-30 21:45:49 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-04-30 21:54:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/261633006/1
6 years, 7 months ago (2014-04-30 21:55:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 23:12:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 23:12:42 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-04-30 23:14:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/261633006/1
6 years, 7 months ago (2014-04-30 23:14:55 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 05:26:45 UTC) #9
Message was sent while issue was closed. 
Change committed as 267445

Powered by Google App Engine
This is Rietveld 408576698