third_party/WebKit/Source/core/fetch/Resource.h - Issue 2616323002: CrossOriginAccessControl: separate access checks and error message generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2616323002: CrossOriginAccessControl: separate access checks and error message generation (Closed)

Patch Set: sync expectation Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index afa7d880e4dfa45fef40abb042186cdb89fafd18..b5fdd2fe7ef675de4902afd7c39f60d2bb61513e 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -214,11 +214,7 @@ class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource>,

virtual void finish(double finishTime);

void finish() { finish(0.0); }

- // FIXME: Remove the stringless variant once all the callsites' error messages

- // are updated.

bool passesAccessControlCheck(SecurityOrigin*) const;

- bool passesAccessControlCheck(SecurityOrigin*,

- String& errorDescription) const;

virtual PassRefPtr<const SharedBuffer> resourceBuffer() const {

return m_data;