Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: ui/native_theme/common_theme.cc

Issue 2616273002: Native Themes: Add table header colors (Closed)
Patch Set: Refactor Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/native_theme/common_theme.cc
diff --git a/ui/native_theme/common_theme.cc b/ui/native_theme/common_theme.cc
index f41e775465dbfc9d7f239159fa9444e5d0ba03b8..2780d13f7342f9fcf6a85e431dc79a1bbe37202e 100644
--- a/ui/native_theme/common_theme.cc
+++ b/ui/native_theme/common_theme.cc
@@ -132,6 +132,9 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
SkColorSetRGB(0xEE, 0xEE, 0xEE);
static const SkColor kTableGroupingIndicatorColor =
SkColorSetRGB(0xCC, 0xCC, 0xCC);
+ // Table Header:
+ static const SkColor kTableHeaderText = SK_ColorBLACK;
+ static const SkColor kTableHeaderSeparator = SkColorSetA(SK_ColorBLACK, 0x14);
// Material spinner/throbber:
static const SkColor kThrobberSpinningColor = gfx::kGoogleBlue500;
static const SkColor kThrobberWaitingColor = SkColorSetRGB(0xA6, 0xA6, 0xA6);
@@ -261,6 +264,14 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
case NativeTheme::kColorId_TableGroupingIndicatorColor:
return kTableGroupingIndicatorColor;
+ // Table Header
+ case NativeTheme::kColorId_TableHeaderText:
+ return kTableHeaderText;
+ case NativeTheme::kColorId_TableHeaderBackground:
+ return base_theme->GetSystemColor(NativeTheme::kColorId_DialogBackground);
Evan Stade 2017/01/19 00:49:22 Instead of adding new colors I'd just use the menu
Tom (Use chromium acct) 2017/01/19 02:03:23 Done.
Evan Stade 2017/01/19 02:04:29 what I meant was the new ColorIds needn't exist.
+ case NativeTheme::kColorId_TableHeaderSeparator:
+ return kTableHeaderSeparator;
+
// FocusableBorder
case NativeTheme::kColorId_FocusedBorderColor:
return gfx::kGoogleBlue500;

Powered by Google App Engine
This is Rietveld 408576698