Native Themes: Add table header colors

ui/native_theme/common_theme.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/native_theme/common_theme.h"
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "ui/base/material_design/material_design_controller.h"
@@ skipping 114 matching lines @@
       SkColorSetRGB(0xEE, 0xEE, 0xEE);
   static const SkColor kTreeArrowColor = SkColorSetRGB(0x7A, 0x7A, 0x7A);
   // Table:
   static const SkColor kTableBackground = SK_ColorWHITE;
   static const SkColor kTableTextColor = SK_ColorBLACK;
   static const SkColor kTableSelectedTextColor = SK_ColorBLACK;
   static const SkColor kTableSelectionBackgroundColor =
       SkColorSetRGB(0xEE, 0xEE, 0xEE);
   static const SkColor kTableGroupingIndicatorColor =
       SkColorSetRGB(0xCC, 0xCC, 0xCC);
+  // Table Header:
+  static const SkColor kTableHeaderText = SK_ColorBLACK;
+  static const SkColor kTableHeaderSeparator = SkColorSetA(SK_ColorBLACK, 0x14);
   // Material spinner/throbber:
   static const SkColor kThrobberSpinningColor = gfx::kGoogleBlue500;
   static const SkColor kThrobberWaitingColor = SkColorSetRGB(0xA6, 0xA6, 0xA6);
   static const SkColor kThrobberLightColor = SkColorSetRGB(0xF4, 0xF8, 0xFD);
 
   switch (color_id) {
     // Dialogs
     case NativeTheme::kColorId_WindowBackground:
     case NativeTheme::kColorId_DialogBackground:
     case NativeTheme::kColorId_BubbleBackground:
@@ skipping 109 matching lines @@
       return kTableTextColor;
     case NativeTheme::kColorId_TableSelectedText:
     case NativeTheme::kColorId_TableSelectedTextUnfocused:
       return kTableSelectedTextColor;
     case NativeTheme::kColorId_TableSelectionBackgroundFocused:
     case NativeTheme::kColorId_TableSelectionBackgroundUnfocused:
       return kTableSelectionBackgroundColor;
     case NativeTheme::kColorId_TableGroupingIndicatorColor:
       return kTableGroupingIndicatorColor;
 
+    // Table Header
+    case NativeTheme::kColorId_TableHeaderText:
+      return kTableHeaderText;
+    case NativeTheme::kColorId_TableHeaderBackground:
+      return base_theme->GetSystemColor(NativeTheme::kColorId_DialogBackground);

[Evan Stade, 2017/01/19 00:49:22]

Instead of adding new colors I'd just use the menu colors that already exist
(which gives us the right thing on an Aura theme and a reasonable thing anywhere
else), i.e.

kEnabledMenuItemForegroundColor
kMenuBackgroundColor
kEnabledMenuButtonBorderColor

[Tom (Use chromium acct), 2017/01/19 02:03:23]

Done.

[Evan Stade, 2017/01/19 02:04:29]

what I meant was the new ColorIds needn't exist.

+    case NativeTheme::kColorId_TableHeaderSeparator:
+      return kTableHeaderSeparator;
+
     // FocusableBorder
     case NativeTheme::kColorId_FocusedBorderColor:
       return gfx::kGoogleBlue500;
     case NativeTheme::kColorId_UnfocusedBorderColor:
       return SkColorSetA(SK_ColorBLACK, 0x66);
 
     // Results Tables
     case NativeTheme::kColorId_ResultsTableNormalBackground:
       return kTextfieldDefaultBackground;
     case NativeTheme::kColorId_ResultsTableHoveredBackground:
@@ skipping 76 matching lines @@
   }
   if (menu_item.corner_radius > 0) {
     const SkScalar radius = SkIntToScalar(menu_item.corner_radius);
     canvas->drawRoundRect(gfx::RectToSkRect(rect), radius, radius, paint);
     return;
   }
   canvas->drawRect(gfx::RectToSkRect(rect), paint);
 }
 
 }  // namespace ui