dart2js-kernel: implement rethrow

dart2js-kernel: implement rethrow

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/0b00989fc4be9e313cc074786192f965f89c4523

[sra1, 2017-01-07 02:04:22]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2017-01-09 19:19:37]

sra@google.com changed reviewers:
+ efortuna@google.com
- sigmund@google.com

[sra1, 2017-01-09 19:20:17]

https://codereview.chromium.org/2616263002/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2616263002/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:19: //SyntheticConstantKind,
I'm fixing this now and reformatting

[Emily Fortuna, 2017-01-09 19:22:34]

lgtm post reformat

[sra1, 2017-01-09 21:13:43]

Description was changed from

==========
dart2js-kernel: implement rethrow
==========

to

==========
dart2js-kernel: implement rethrow

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0b00989fc4be9e313cc074786192f965f89c4523
==========

[sra1, 2017-01-09 21:13:44]

Committed patchset #4 (id:60001) manually as
0b00989fc4be9e313cc074786192f965f89c4523 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-01-11 19:13:03]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-11 19:13:04]

lgtm

https://codereview.chromium.org/2616263002/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2616263002/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2224: SourceInformation
sourceInformation = null;
what do we generally want to do for with source-infos at this time. Do we want
to wait and add them all later, or do we want to use the adapter to get the AST
node and then remove the adapter? For example, here we could do:

sourceInformationBuilder.buildThrow(astAdapter.getNode(rethrowNode))

[Emily Fortuna, 2017-01-11 21:19:54]

https://codereview.chromium.org/2616263002/diff/60001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2616263002/diff/60001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:2224: SourceInformation
sourceInformation = null;
On 2017/01/11 19:13:04, Siggi Cherem (dart-lang) wrote:
> what do we generally want to do for with source-infos at this time. Do we want
> to wait and add them all later, or do we want to use the adapter to get the
AST
> node and then remove the adapter? For example, here we could do:
> 
> sourceInformationBuilder.buildThrow(astAdapter.getNode(rethrowNode))

I had been avoiding them and adding TODOs, but it's probably better and less
error prone to add the machinery in now to the adapter and add the rest as we
get further along.