Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 261623004: Hook prerender into non-CURRENT_TAB dispositions. (Closed)

Created:
6 years, 7 months ago by davidben
Modified:
6 years, 7 months ago
Reviewers:
sky, tburkard
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Hook prerender into non-CURRENT_TAB dispositions. SwapInternal checks if CoreTabHelper::delegate is NULL now, and a non-CURRENT_TAB disposition would require the asynchronous codepath anyway, so it's fine that the WebContents is still to be attached. BUG=345474 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +8 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
davidben
This turned out to be pretty easy. And it seems middle-clicking makes a new BrowsingInstance ...
6 years, 7 months ago (2014-04-30 16:54:05 UTC) #1
tburkard
lgtm
6 years, 7 months ago (2014-05-06 18:50:10 UTC) #2
sky
LGTM
6 years, 7 months ago (2014-05-07 21:38:26 UTC) #3
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-05-07 21:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/261623004/1
6 years, 7 months ago (2014-05-07 21:42:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 23:09:38 UTC) #6
davidben
On 2014/05/07 23:09:38, I haz the power (commit-bot) wrote: > FYI, CQ is re-trying this ...
6 years, 7 months ago (2014-05-07 23:28:07 UTC) #7
davidben
The CQ bit was unchecked by davidben@chromium.org
6 years, 7 months ago (2014-05-07 23:28:09 UTC) #8
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 7 months ago (2014-05-13 21:56:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/261623004/1
6 years, 7 months ago (2014-05-13 22:04:48 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 23:41:59 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 01:09:25 UTC) #12
Message was sent while issue was closed.
Change committed as 270278

Powered by Google App Engine
This is Rietveld 408576698