Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 261623002: Network Panel: add method and status code filters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkPanel.js
diff --git a/Source/devtools/front_end/network/NetworkPanel.js b/Source/devtools/front_end/network/NetworkPanel.js
index 6c8e26a6f56df639b5b052ce5b66d712517fc42a..909609b1728fec07bcf43839c92b7c24c7556c33 100644
--- a/Source/devtools/front_end/network/NetworkPanel.js
+++ b/Source/devtools/front_end/network/NetworkPanel.js
@@ -851,7 +851,9 @@ WebInspector.NetworkLogView.prototype = {
return;
this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Domain, request.domain);
+ this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Method, request.requestMethod);
this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.MimeType, request.mimeType);
+ this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.StatusCode, "" + request.statusCode);
var responseHeaders = request.responseHeaders;
for (var i = 0, l = responseHeaders.length; i < l; ++i)
@@ -1376,6 +1378,9 @@ WebInspector.NetworkLogView.prototype = {
case WebInspector.NetworkPanel.FilterType.HasResponseHeader:
return WebInspector.NetworkLogView._requestResponseHeaderFilter.bind(null, value);
+ case WebInspector.NetworkPanel.FilterType.Method:
+ return WebInspector.NetworkLogView._requestMethodFilter.bind(null, value);
+
case WebInspector.NetworkPanel.FilterType.MimeType:
return WebInspector.NetworkLogView._requestMimeTypeFilter.bind(null, value);
@@ -1387,6 +1392,9 @@ WebInspector.NetworkLogView.prototype = {
case WebInspector.NetworkPanel.FilterType.SetCookieValue:
return WebInspector.NetworkLogView._requestSetCookieValueFilter.bind(null, value);
+
+ case WebInspector.NetworkPanel.FilterType.StatusCode:
+ return WebInspector.NetworkLogView._statusCodeFilter.bind(null, value);
}
return this._createTextFilter(type + ":" + value);
},
@@ -1589,6 +1597,16 @@ WebInspector.NetworkLogView._requestResponseHeaderFilter = function(value, reque
* @param {!WebInspector.NetworkRequest} request
* @return {boolean}
*/
+WebInspector.NetworkLogView._requestMethodFilter = function(value, request)
+{
+ return request.requestMethod === value;
+}
+
+/**
+ * @param {string} value
+ * @param {!WebInspector.NetworkRequest} request
+ * @return {boolean}
+ */
WebInspector.NetworkLogView._requestMimeTypeFilter = function(value, request)
{
return request.mimeType === value;
@@ -1640,6 +1658,16 @@ WebInspector.NetworkLogView._requestSetCookieValueFilter = function(value, reque
}
/**
+ * @param {string} value
+ * @param {!WebInspector.NetworkRequest} request
+ * @return {boolean}
+ */
+WebInspector.NetworkLogView._statusCodeFilter = function(value, request)
+{
+ return ("" + request.statusCode) === value;
+}
+
+/**
* @param {!WebInspector.NetworkRequest} request
* @return {boolean}
*/
@@ -1748,10 +1776,12 @@ WebInspector.NetworkPanel = function()
WebInspector.NetworkPanel.FilterType = {
Domain: "Domain",
HasResponseHeader: "HasResponseHeader",
+ Method: "Method",
vsevik 2014/04/30 11:58:55 We should do something about this case sensitive m
MimeType: "MimeType",
SetCookieDomain: "SetCookieDomain",
SetCookieName: "SetCookieName",
- SetCookieValue: "SetCookieValue"
+ SetCookieValue: "SetCookieValue",
+ StatusCode: "StatusCode"
};
/** @type {!Array.<string>} */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698