Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 261623002: Network Panel: add method and status code filters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 844
845 /** 845 /**
846 * @param {!WebInspector.NetworkRequest} request 846 * @param {!WebInspector.NetworkRequest} request
847 */ 847 */
848 _refreshRequest: function(request) 848 _refreshRequest: function(request)
849 { 849 {
850 if (!this._requestsById[request.requestId]) 850 if (!this._requestsById[request.requestId])
851 return; 851 return;
852 852
853 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Dom ain, request.domain); 853 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Dom ain, request.domain);
854 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Met hod, request.requestMethod);
854 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Mim eType, request.mimeType); 855 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Mim eType, request.mimeType);
856 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType.Sta tusCode, "" + request.statusCode);
855 857
856 var responseHeaders = request.responseHeaders; 858 var responseHeaders = request.responseHeaders;
857 for (var i = 0, l = responseHeaders.length; i < l; ++i) 859 for (var i = 0, l = responseHeaders.length; i < l; ++i)
858 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .HasResponseHeader, responseHeaders[i].name); 860 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .HasResponseHeader, responseHeaders[i].name);
859 var cookies = request.responseCookies; 861 var cookies = request.responseCookies;
860 for (var i = 0, l = cookies ? cookies.length : 0; i < l; ++i) { 862 for (var i = 0, l = cookies ? cookies.length : 0; i < l; ++i) {
861 var cookie = cookies[i]; 863 var cookie = cookies[i];
862 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .SetCookieDomain, cookie.domain()); 864 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .SetCookieDomain, cookie.domain());
863 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .SetCookieName, cookie.name()); 865 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .SetCookieName, cookie.name());
864 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .SetCookieValue, cookie.value()); 866 this._suggestionBuilder.addItem(WebInspector.NetworkPanel.FilterType .SetCookieValue, cookie.value());
(...skipping 504 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 * @return {!WebInspector.NetworkLogView.Filter} 1371 * @return {!WebInspector.NetworkLogView.Filter}
1370 */ 1372 */
1371 _createFilter: function(type, value) { 1373 _createFilter: function(type, value) {
1372 switch (type) { 1374 switch (type) {
1373 case WebInspector.NetworkPanel.FilterType.Domain: 1375 case WebInspector.NetworkPanel.FilterType.Domain:
1374 return WebInspector.NetworkLogView._requestDomainFilter.bind(null, v alue); 1376 return WebInspector.NetworkLogView._requestDomainFilter.bind(null, v alue);
1375 1377
1376 case WebInspector.NetworkPanel.FilterType.HasResponseHeader: 1378 case WebInspector.NetworkPanel.FilterType.HasResponseHeader:
1377 return WebInspector.NetworkLogView._requestResponseHeaderFilter.bind (null, value); 1379 return WebInspector.NetworkLogView._requestResponseHeaderFilter.bind (null, value);
1378 1380
1381 case WebInspector.NetworkPanel.FilterType.Method:
1382 return WebInspector.NetworkLogView._requestMethodFilter.bind(null, v alue);
1383
1379 case WebInspector.NetworkPanel.FilterType.MimeType: 1384 case WebInspector.NetworkPanel.FilterType.MimeType:
1380 return WebInspector.NetworkLogView._requestMimeTypeFilter.bind(null, value); 1385 return WebInspector.NetworkLogView._requestMimeTypeFilter.bind(null, value);
1381 1386
1382 case WebInspector.NetworkPanel.FilterType.SetCookieDomain: 1387 case WebInspector.NetworkPanel.FilterType.SetCookieDomain:
1383 return WebInspector.NetworkLogView._requestSetCookieDomainFilter.bin d(null, value); 1388 return WebInspector.NetworkLogView._requestSetCookieDomainFilter.bin d(null, value);
1384 1389
1385 case WebInspector.NetworkPanel.FilterType.SetCookieName: 1390 case WebInspector.NetworkPanel.FilterType.SetCookieName:
1386 return WebInspector.NetworkLogView._requestSetCookieNameFilter.bind( null, value); 1391 return WebInspector.NetworkLogView._requestSetCookieNameFilter.bind( null, value);
1387 1392
1388 case WebInspector.NetworkPanel.FilterType.SetCookieValue: 1393 case WebInspector.NetworkPanel.FilterType.SetCookieValue:
1389 return WebInspector.NetworkLogView._requestSetCookieValueFilter.bind (null, value); 1394 return WebInspector.NetworkLogView._requestSetCookieValueFilter.bind (null, value);
1395
1396 case WebInspector.NetworkPanel.FilterType.StatusCode:
1397 return WebInspector.NetworkLogView._statusCodeFilter.bind(null, valu e);
1390 } 1398 }
1391 return this._createTextFilter(type + ":" + value); 1399 return this._createTextFilter(type + ":" + value);
1392 }, 1400 },
1393 1401
1394 _filterRequests: function() 1402 _filterRequests: function()
1395 { 1403 {
1396 this._removeAllHighlights(); 1404 this._removeAllHighlights();
1397 this._filteredOutRequests.clear(); 1405 this._filteredOutRequests.clear();
1398 1406
1399 var nodes = this._dataGrid.rootNode().children; 1407 var nodes = this._dataGrid.rootNode().children;
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
1582 WebInspector.NetworkLogView._requestResponseHeaderFilter = function(value, reque st) 1590 WebInspector.NetworkLogView._requestResponseHeaderFilter = function(value, reque st)
1583 { 1591 {
1584 return request.responseHeaderValue(value) !== undefined; 1592 return request.responseHeaderValue(value) !== undefined;
1585 } 1593 }
1586 1594
1587 /** 1595 /**
1588 * @param {string} value 1596 * @param {string} value
1589 * @param {!WebInspector.NetworkRequest} request 1597 * @param {!WebInspector.NetworkRequest} request
1590 * @return {boolean} 1598 * @return {boolean}
1591 */ 1599 */
1600 WebInspector.NetworkLogView._requestMethodFilter = function(value, request)
1601 {
1602 return request.requestMethod === value;
1603 }
1604
1605 /**
1606 * @param {string} value
1607 * @param {!WebInspector.NetworkRequest} request
1608 * @return {boolean}
1609 */
1592 WebInspector.NetworkLogView._requestMimeTypeFilter = function(value, request) 1610 WebInspector.NetworkLogView._requestMimeTypeFilter = function(value, request)
1593 { 1611 {
1594 return request.mimeType === value; 1612 return request.mimeType === value;
1595 } 1613 }
1596 1614
1597 /** 1615 /**
1598 * @param {string} value 1616 * @param {string} value
1599 * @param {!WebInspector.NetworkRequest} request 1617 * @param {!WebInspector.NetworkRequest} request
1600 * @return {boolean} 1618 * @return {boolean}
1601 */ 1619 */
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
1633 { 1651 {
1634 var cookies = request.responseCookies; 1652 var cookies = request.responseCookies;
1635 for (var i = 0, l = cookies ? cookies.length : 0; i < l; ++i) { 1653 for (var i = 0, l = cookies ? cookies.length : 0; i < l; ++i) {
1636 if (cookies[i].value() === value) 1654 if (cookies[i].value() === value)
1637 return false; 1655 return false;
1638 } 1656 }
1639 return false; 1657 return false;
1640 } 1658 }
1641 1659
1642 /** 1660 /**
1661 * @param {string} value
1662 * @param {!WebInspector.NetworkRequest} request
1663 * @return {boolean}
1664 */
1665 WebInspector.NetworkLogView._statusCodeFilter = function(value, request)
1666 {
1667 return ("" + request.statusCode) === value;
1668 }
1669
1670 /**
1643 * @param {!WebInspector.NetworkRequest} request 1671 * @param {!WebInspector.NetworkRequest} request
1644 * @return {boolean} 1672 * @return {boolean}
1645 */ 1673 */
1646 WebInspector.NetworkLogView.HTTPRequestsFilter = function(request) 1674 WebInspector.NetworkLogView.HTTPRequestsFilter = function(request)
1647 { 1675 {
1648 return request.parsedURL.isValid && (request.scheme in WebInspector.NetworkL ogView.HTTPSchemas); 1676 return request.parsedURL.isValid && (request.scheme in WebInspector.NetworkL ogView.HTTPSchemas);
1649 } 1677 }
1650 1678
1651 /** 1679 /**
1652 * @param {!WebInspector.NetworkRequest} request 1680 * @param {!WebInspector.NetworkRequest} request
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1741 { 1769 {
1742 return this._networkItemView.currentSourceFrame(); 1770 return this._networkItemView.currentSourceFrame();
1743 } 1771 }
1744 WebInspector.GoToLineDialog.install(this, sourceFrameGetter.bind(this)); 1772 WebInspector.GoToLineDialog.install(this, sourceFrameGetter.bind(this));
1745 } 1773 }
1746 1774
1747 /** @enum {string} */ 1775 /** @enum {string} */
1748 WebInspector.NetworkPanel.FilterType = { 1776 WebInspector.NetworkPanel.FilterType = {
1749 Domain: "Domain", 1777 Domain: "Domain",
1750 HasResponseHeader: "HasResponseHeader", 1778 HasResponseHeader: "HasResponseHeader",
1779 Method: "Method",
vsevik 2014/04/30 11:58:55 We should do something about this case sensitive m
1751 MimeType: "MimeType", 1780 MimeType: "MimeType",
1752 SetCookieDomain: "SetCookieDomain", 1781 SetCookieDomain: "SetCookieDomain",
1753 SetCookieName: "SetCookieName", 1782 SetCookieName: "SetCookieName",
1754 SetCookieValue: "SetCookieValue" 1783 SetCookieValue: "SetCookieValue",
1784 StatusCode: "StatusCode"
1755 }; 1785 };
1756 1786
1757 /** @type {!Array.<string>} */ 1787 /** @type {!Array.<string>} */
1758 WebInspector.NetworkPanel._searchKeys = Object.values(WebInspector.NetworkPanel. FilterType); 1788 WebInspector.NetworkPanel._searchKeys = Object.values(WebInspector.NetworkPanel. FilterType);
1759 1789
1760 WebInspector.NetworkPanel.prototype = { 1790 WebInspector.NetworkPanel.prototype = {
1761 _onFiltersToggled: function(event) 1791 _onFiltersToggled: function(event)
1762 { 1792 {
1763 var toggled = /** @type {boolean} */ (event.data); 1793 var toggled = /** @type {boolean} */ (event.data);
1764 this._filtersContainer.classList.toggle("hidden", !toggled); 1794 this._filtersContainer.classList.toggle("hidden", !toggled);
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
2894 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 2924 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
2895 { 2925 {
2896 var aValue = a._request[propertyName]; 2926 var aValue = a._request[propertyName];
2897 var bValue = b._request[propertyName]; 2927 var bValue = b._request[propertyName];
2898 if (aValue > bValue) 2928 if (aValue > bValue)
2899 return revert ? -1 : 1; 2929 return revert ? -1 : 1;
2900 if (bValue > aValue) 2930 if (bValue > aValue)
2901 return revert ? 1 : -1; 2931 return revert ? 1 : -1;
2902 return 0; 2932 return 0;
2903 } 2933 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698