Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

Issue 2616213003: Get more consistent decisions if a statement is constant in templates (Closed)
Patch Set: consistant-consts Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
index 3f55421bb4356a33149b2f4e24db8e3399384f21..4b2f89f3ba4a7332db0feace840a1fa5776cb330 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
@@ -33,10 +33,10 @@ class C {
const int kFunctionConstantFromExpression = 4 + 6;
const int kFunctionConstantFromOtherConsts =
kFunctionConstant + kFunctionConstantFromExpression;
- // These don't do the right thing right now, but names like this don't
- // exist in blink (hopefully).
- const int kShould_be_renamed_to_a_const = 9 - 2;
- const int kShould_also_be_renamed_to_a_const =
+ // These are constants but they are hacker_case, so we just leave them as
+ // is since the author explicitly did this.
+ const int should_not_be_renamed_to_a_const = 9 - 2;
+ const int should_not_also_be_renamed_to_a_const =
kFunctionConstant + kFunctionConstantFromOtherConsts;
const int not_compile_time_const = kFunctionConstant + Function();
}

Powered by Google App Engine
This is Rietveld 408576698