Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: remoting/codec/webrtc_video_encoder.h

Issue 2616213002: Fix WebrtcVideoStream to handle failed capture requests. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/codec/webrtc_video_encoder_vpx.h » ('j') | remoting/protocol/connection_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/webrtc_video_encoder.h
diff --git a/remoting/codec/webrtc_video_encoder.h b/remoting/codec/webrtc_video_encoder.h
index be0f988a6b48d83395458bc0fa6efd1ed3d5f0cd..bf097c273e131ab9023c1981447003aaa105d2d9 100644
--- a/remoting/codec/webrtc_video_encoder.h
+++ b/remoting/codec/webrtc_video_encoder.h
@@ -53,12 +53,13 @@ class WebrtcVideoEncoder {
virtual ~WebrtcVideoEncoder() {}
- // Encode an image stored in |frame|. If |frame.updated_region()| is empty
- // then the encoder may return a packet (e.g. to top-off previously-encoded
+ // Encode an image stored in |frame|. If frame.updated_region() is empty
+ // then the encoder may return a frame (e.g. to top-off previously-encoded
// portions of the frame to higher quality) or return nullptr to indicate that
- // there is no work to do.
+ // there is no work to do. |frame| may be nullptr. This case must be handled
+ // the same as if frame.updated_region() is empty.
virtual std::unique_ptr<EncodedFrame> Encode(
- const webrtc::DesktopFrame& frame,
+ const webrtc::DesktopFrame* frame,
const FrameParams& param) = 0;
};
« no previous file with comments | « no previous file | remoting/codec/webrtc_video_encoder_vpx.h » ('j') | remoting/protocol/connection_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698