android: Remove DeviceDisplayInfo from ResourceBundle

android: Remove DeviceDisplayInfo from ResourceBundle

Instead, copy the logic to get the primary display density in
resource_bundle_android. Note this is not using Display to avoid
initializing Display backend in any child process.

BUG=625089

[boliu, 2017-01-07 00:31:00]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 00:31:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-01-07 00:34:59]

boliu@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[boliu, 2017-01-07 00:35:00]

ptal, for android review, will add owner stamp after

[gone, 2017-01-07 01:05:08]

lgtm

[boliu, 2017-01-07 01:07:35]

boliu@chromium.org changed reviewers:
+ sky@chromium.org

[boliu, 2017-01-07 01:07:35]

+sky for owner stamp

[boliu, 2017-01-07 01:54:08]

The CQ bit was unchecked by boliu@chromium.org

[boliu, 2017-01-07 02:01:20]

Ahh, InitSharedInstance is called before Screen is initialized on android. Need
to fix that too

[boliu, 2017-01-07 02:24:01]

On 2017/01/07 02:01:20, boliu wrote:
> Ahh, InitSharedInstance is called before Screen is initialized on android.
Need
> to fix that too

Err, this is somewhat involved. Hold off review for now..

Browser is easy to fix, but I didn't know this is called from child process as
well. I'd like to avoid using display from child processes on android, so I
think I'll pass the density to child process in some other way.

[boliu, 2017-01-07 20:31:54]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-07 20:32:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 21:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-07 21:25:44]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-01-09 22:43:06]

Description was changed from

==========
android: Use Display in ResourceBundle

This removes usage of deprecated DeviceDisplayInfo. Note that the
HasForceDeviceScaleFactor check is integrated into Display already so no
longer needs to be repeated here.

BUG=625089
==========

to

==========
android: Use Display in ResourceBundle

This removes usage of deprecated DeviceDisplayInfo. Instead, copy the logic
to get the primary display density. Note this is not using Display to avoid
initializing Display backend in any child process.

BUG=625089
==========

[boliu, 2017-01-09 22:50:28]

boliu@chromium.org changed reviewers:
- sky@chromium.org

[boliu, 2017-01-09 22:50:29]

Dan, can you take another look, and let me know how much you hate this..

I don't want to initialize Display in child processes. imo it's wrong on
principle.

I also considered passing density to child through command line args
This would work, but would involve either 1) pass the arg in content, so need
distinguish the resource init call between browser and renderer, or 2) pass the
arg from a whole bunch of different content embedders because resource init is
spread out as well. Also adding long lived command line args kinda sucks.

So I did this instead.. I just shoved the jni call into the nearest jni file. On
second though, I can probably shove it in display_android_manager.h/cc..

Thoughts?

[boliu, 2017-01-09 23:43:11]

On 2017/01/09 22:50:29, boliu wrote:
> Dan, can you take another look, and let me know how much you hate this..
> 
> I don't want to initialize Display in child processes. imo it's wrong on
> principle.
> 
> I also considered passing density to child through command line args
> This would work, but would involve either 1) pass the arg in content, so need
> distinguish the resource init call between browser and renderer, or 2) pass
the
> arg from a whole bunch of different content embedders because resource init is
> spread out as well. Also adding long lived command line args kinda sucks.
> 
> So I did this instead.. I just shoved the jni call into the nearest jni file.
On
> second though, I can probably shove it in display_android_manager.h/cc..

Tried that. Has DEPS problem. resource_bundle.cc can't include from ui/android,
and I agree with that rule..

> 
> Thoughts?

[boliu, 2017-01-10 00:52:50]

Description was changed from

==========
android: Use Display in ResourceBundle

This removes usage of deprecated DeviceDisplayInfo. Instead, copy the logic
to get the primary display density. Note this is not using Display to avoid
initializing Display backend in any child process.

BUG=625089
==========

to

==========
android: Use Display in ResourceBundle

This removes usage of deprecated DeviceDisplayInfo. Instead, copy the logic
to get the primary display density in resource_bundle_android. Note this is not
using Display to avoid initializing Display backend in any child process.

BUG=625089
==========

[boliu, 2017-01-10 00:53:31]

ptal

moved to resource_bundle_android.. and I was wrong on chat, there was already a
java ResourceBundle

[gone, 2017-01-10 01:03:40]

lgtm % updating the commit message as necessary

[boliu, 2017-01-10 01:09:52]

Description was changed from

==========
android: Use Display in ResourceBundle

This removes usage of deprecated DeviceDisplayInfo. Instead, copy the logic
to get the primary display density in resource_bundle_android. Note this is not
using Display to avoid initializing Display backend in any child process.

BUG=625089
==========

to

==========
android: Remove DeviceDisplayInfo from ResourceBundle

Instead, copy the logic to get the primary display density in
resource_bundle_android.
Note this is not using Display to avoid initializing Display backend in any
child
process.

BUG=625089
==========

[boliu, 2017-01-10 01:10:05]

Description was changed from

==========
android: Remove DeviceDisplayInfo from ResourceBundle

Instead, copy the logic to get the primary display density in
resource_bundle_android.
Note this is not using Display to avoid initializing Display backend in any
child
process.

BUG=625089
==========

to

==========
android: Remove DeviceDisplayInfo from ResourceBundle

Instead, copy the logic to get the primary display density in
resource_bundle_android. Note this is not using Display to avoid initializing
Display
backend in any child process.

BUG=625089
==========

[boliu, 2017-01-10 01:11:13]

Description was changed from

==========
android: Remove DeviceDisplayInfo from ResourceBundle

Instead, copy the logic to get the primary display density in
resource_bundle_android. Note this is not using Display to avoid initializing
Display
backend in any child process.

BUG=625089
==========

to

==========
android: Remove DeviceDisplayInfo from ResourceBundle

Instead, copy the logic to get the primary display density in
resource_bundle_android. Note this is not using Display to avoid
initializing Display backend in any child process.

BUG=625089
==========

[boliu, 2017-01-10 01:12:25]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 01:13:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[boliu, 2017-01-10 01:15:23]

boliu@chromium.org changed reviewers:
+ sky@chromium.org, tedchoc@chromium.org

[boliu, 2017-01-10 01:15:24]

+sky back for stamping resource_bundle.cc
+tedchoc for ui/android

[commit-bot: I haz the power, 2017-01-10 03:16:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 03:16:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sky, 2017-01-10 15:53:22]

LGTM

[boliu, 2017-01-10 16:18:10]

The CQ bit was checked by boliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 16:18:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ted C, 2017-01-10 16:34:54]

On 2017/01/10 15:53:22, sky wrote:
> LGTM

lgtm

[commit-bot: I haz the power, 2017-01-10 16:54:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 16:54:08]

Dry run: This issue passed the CQ dry run.

[boliu, 2017-01-10 16:57:30]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-01-10 16:57:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 17:02:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484067450253290,
"parent_rev": "a52cc54f7f0a41e783bcfe2c4944989f3a357236", "commit_rev":
"2d67dc211444eba23d7c441f590f2018acea53fa"}

[commit-bot: I haz the power, 2017-01-10 17:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 17:08:36]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[boliu, 2017-01-10 17:10:05]

On 2017/01/10 17:08:36, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Guess I should be happy it didn't try to commit the CL twice..