tools/svndiff.py - Issue 26162004: revert unintentional checkin of svndiff.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/svndiff.py

Issue 26162004: revert unintentional checkin of svndiff.py (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/svndiff.py

diff --git a/tools/svndiff.py b/tools/svndiff.py

index 1821d22e088cb7630bb4d01b6c6d0928a596e13e..9e51eee22cd643244e924657e2dc68cff78a4fd5 100755

--- a/tools/svndiff.py

+++ b/tools/svndiff.py

@@ -147,13 +147,10 @@ def _CallJsonDiff(old_json_path, new_json_path,

imagename=imagename,

hash_type=gm_json.JSONKEY_HASHTYPE_BITMAP_64BITMD5,

hash_digest=old_checksum)

- try:

- _DownloadUrlToFile(

- source_url=old_image_url,

- dest_path=os.path.join(old_flattened_dir,

- filename_prefix + imagename))

- except:

- print "unable to find image ", os.path.join(old_flattened_dir, filename_prefix + imagename)

+ _DownloadUrlToFile(

+ source_url=old_image_url,

+ dest_path=os.path.join(old_flattened_dir,

+ filename_prefix + imagename))

new_checksum = results['new']

if new_checksum:

« no previous file with comments | « no previous file | no next file » | no next file with comments »