Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: dashboard/dashboard/elements/alerts-table.html

Issue 2616153002: Create debug dialog for data stoppage alerts. (Closed)
Patch Set: Addressed review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/elements/alerts-page.html ('k') | dashboard/dashboard/elements/chart-container.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/alerts-table.html
diff --git a/dashboard/dashboard/elements/alerts-table.html b/dashboard/dashboard/elements/alerts-table.html
index cd621e2363b86bac4df06e5548acdd0228ee7120..e080c5b7aa2c3a6c52fa37af2cbb0aea0174957a 100644
--- a/dashboard/dashboard/elements/alerts-table.html
+++ b/dashboard/dashboard/elements/alerts-table.html
@@ -12,6 +12,7 @@ found in the LICENSE file.
<link rel="import" href="/dashboard/elements/bisect-status.html">
<link rel="import" href="/dashboard/elements/bug-info-span.html">
<link rel="import" href="/dashboard/elements/revision-range.html">
+<link rel="import" href="/dashboard/elements/stoppage-alert-debug-button.html">
<link rel="import" href="/dashboard/elements/triage-dialog.html">
<link rel="import" href="/dashboard/static/simple_xhr.html">
<link rel="import" href="/dashboard/static/uri.html">
@@ -70,19 +71,19 @@ found in the LICENSE file.
#alerts #test {
max-width:50%;
- min-width: 20%;
+ min-width: 20%;
width: 30%;
}
#alerts #testsuite {
max-width:20%;
- min-width: 10%;
+ min-width: 10%;
width: 15%;
}
#alerts #bot {
max-width:20%;
- min-width: 10%;
+ min-width: 10%;
width: 10%;
}
@@ -382,10 +383,15 @@ found in the LICENSE file.
<td class="testsuite">{{item.testsuite}}</td>
<td class="test">{{item.test}}</td>
- <template is="dom-repeat" items="{{extraColumns}}" as="column"
+ <template is="dom-repeat" items="{{extraColumns}}" as="column"
index-as="colnum">
<td class$="{{column.key}}" hidden$={{hideUnitsColumn(column.key)}}>
{{computeExtraColumnValue(item, column.key)}}
+ <template is="dom-if" if="{{isDebugButtonKey(column.key)}}">
+ <stoppage-alert-debug-button
+ alert-key="{{item.key}}"
+ bug-id="{{item.bug_id}}"></stoppage-alert-debug-button>
+ </template>
</td>
</template>
</tr>
@@ -547,6 +553,8 @@ found in the LICENSE file.
*/
hideUnitsColumn: key => key === 'units',
+ isDebugButtonKey: key => key === 'debug_button',
+
setAlertList: function(i, property, value) {
this.set('alertList.' + i + '.' + property, value);
},
« no previous file with comments | « dashboard/dashboard/elements/alerts-page.html ('k') | dashboard/dashboard/elements/chart-container.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698