Flatten inferrer implementation

Flatten inferrer implementation

- collapse MinimalInferrerEngine, InferrerEngine and TypeGraphEngine into InferrerEngine
- collapse TypeSystem and TypeInformationSystem into TypeSystem
- deparameterize classes

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/eec5f4fd5e7801ce1e04df2fec6010678b758a9d

[Johnni Winther, 2017-01-06 14:15:36]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-06 18:59:56]

lgtm! with a couple suggestions, we can do these in separate steps if you
prefer, but it might be nice to do upfront:

- seems like inferrer_visitor.dart now has no visitor in it, just scopes and
local handlers, maybe rename the file "locals_handler.dart" or something else?

- We could remove some words from "SimpleTypeInferrerVisitor" (e.g.
"InferrerVisitor" will do), but maybe better to describe what it does, how about
"FunctionGraphBuilder" or "ElementGraphBuilder"? similarly, I'd rename the file
"simple_type_inferrer.dart" to "builder.dart".

https://codereview.chromium.org/2616103002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2616103002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:721: * the wrong modelling of
default values of optional parameters of
modelling => modeling

[Johnni Winther, 2017-01-09 08:51:18]

On 2017/01/06 18:59:56, Siggi Cherem (dart-lang) wrote:
> lgtm! with a couple suggestions, we can do these in separate steps if you
> prefer, but it might be nice to do upfront:
> 
> - seems like inferrer_visitor.dart now has no visitor in it, just scopes and
> local handlers, maybe rename the file "locals_handler.dart" or something else?
> 
> - We could remove some words from "SimpleTypeInferrerVisitor" (e.g.
> "InferrerVisitor" will do), but maybe better to describe what it does, how
about
> "FunctionGraphBuilder" or "ElementGraphBuilder"? similarly, I'd rename the
file
> "simple_type_inferrer.dart" to "builder.dart".

Will handle these in a follow-up.

[Johnni Winther, 2017-01-09 09:01:49]

https://codereview.chromium.org/2616103002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/inferrer_engine.dart (right):

https://codereview.chromium.org/2616103002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/inferrer_engine.dart:721: * the wrong modelling of
default values of optional parameters of
On 2017/01/06 18:59:56, Siggi Cherem (dart-lang) wrote:
> modelling => modeling

Done.

[Johnni Winther, 2017-01-09 09:06:18]

Description was changed from

==========
Flatten inferrer implementation

- collapse MinimalInferrerEngine, InferrerEngine and TypeGraphEngine into
InferrerEngine
- collapse TypeSystem and TypeInformationSystem into TypeSystem
- deparameterize classes
==========

to

==========
Flatten inferrer implementation

- collapse MinimalInferrerEngine, InferrerEngine and TypeGraphEngine into
InferrerEngine
- collapse TypeSystem and TypeInformationSystem into TypeSystem
- deparameterize classes

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/eec5f4fd5e7801ce1e04df2fec6010678b758a9d
==========

[Johnni Winther, 2017-01-09 09:06:19]

Committed patchset #3 (id:40001) manually as
eec5f4fd5e7801ce1e04df2fec6010678b758a9d (presubmit successful).