chrome/browser/extensions/extension_icon_image_unittest.cc - Issue 26161002: Refactored loading of applications / extensions icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_icon_image_unittest.cc

Issue 26161002: Refactored loading of applications / extensions icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO and comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/image_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_icon_image_unittest.cc

diff --git a/chrome/browser/extensions/extension_icon_image_unittest.cc b/chrome/browser/extensions/extension_icon_image_unittest.cc

index fd35ee9b4bf888cec87d485c12fe79afd5eb6e64..1e73efaa297df6100f873acf37a131d17b69e49d 100644

--- a/chrome/browser/extensions/extension_icon_image_unittest.cc

+++ b/chrome/browser/extensions/extension_icon_image_unittest.cc

@@ -88,7 +88,8 @@ class TestImageLoader {

int size) {

image_loaded_ = false;

- image_loader_.LoadImageAsync(

+ image_loader_.reset(new extensions::ImageLoader(NULL));

+ image_loader_->LoadImageAsync(

extension_, extension_->GetResource(path), gfx::Size(size, size),

base::Bind(&TestImageLoader::OnImageLoaded,

base::Unretained(this)));

@@ -111,7 +112,7 @@ class TestImageLoader {

bool waiting_;

bool image_loaded_;

gfx::Image image_;

- extensions::ImageLoader image_loader_;

+ scoped_ptr<extensions::ImageLoader> image_loader_;

DISALLOW_COPY_AND_ASSIGN(TestImageLoader);

};