[ng_layout] Fix wrong percent_resolution_size

third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_constraint_space.h"
 
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
@@ skipping 34 matching lines @@
   // XXX for orthogonal writing mode this is not right
   LayoutUnit available_logical_width =
       std::max(LayoutUnit(), box.containingBlockLogicalWidthForContent());
   LayoutUnit available_logical_height;
   if (!box.parent()) {
     available_logical_height = box.view()->viewLogicalHeightForPercentages();
   } else if (box.containingBlock()) {
     available_logical_height =
         box.containingBlock()->availableLogicalHeightForPercentageComputation();
   }
+  NGLogicalSize percentage_size = {available_logical_width,
+                                   available_logical_height};

[cbiesinger, 2017/01/10 19:45:03]

While you're touching this, I'd also make this other change:

  NGLogicalSize available_size = percentage_size;
then in the ifs change available_size.{inline,block}_size. I think that would be
clear. It would also rename the ambiguously-named "size" variable, which is
another plus :)

[atotic, 2017/01/10 21:53:20]

done

   // When we have an override size, the available_logical_{width,height} will be
   // used as the final size of the box, so it has to include border and
   // padding.
   if (box.hasOverrideLogicalContentWidth()) {
     available_logical_width =
         box.borderAndPaddingLogicalWidth() + box.overrideLogicalContentWidth();
     fixed_inline = true;
   }
   if (box.hasOverrideLogicalContentHeight()) {
     available_logical_height = box.borderAndPaddingLogicalHeight() +
                                box.overrideLogicalContentHeight();
     fixed_block = true;
   }
 
   bool is_new_fc =
       box.isLayoutBlock() && toLayoutBlock(box).createsNewFormattingContext();
 
   NGLogicalSize size = {available_logical_width, available_logical_height};
   auto writing_mode = FromPlatformWritingMode(box.styleRef().getWritingMode());
   return NGConstraintSpaceBuilder(writing_mode)
       .SetAvailableSize(size)
-      .SetPercentageResolutionSize(size)
+      .SetPercentageResolutionSize(percentage_size)
       .SetIsInlineDirectionTriggersScrollbar(
           box.styleRef().overflowInlineDirection() == EOverflow::Auto)
       .SetIsBlockDirectionTriggersScrollbar(
           box.styleRef().overflowBlockDirection() == EOverflow::Auto)
       .SetIsFixedSizeInline(fixed_inline)
       .SetIsFixedSizeBlock(fixed_block)
       .SetIsShrinkToFit(
           box.sizesLogicalWidthToFitContent(box.styleRef().logicalWidth()))
       .SetIsNewFormattingContext(is_new_fc)
       .SetTextDirection(box.styleRef().direction())
@@ skipping 21 matching lines @@
 
 String NGConstraintSpace::ToString() const {
   return String::format("%s,%s %sx%s",
                         offset_.inline_offset.toString().ascii().data(),
                         offset_.block_offset.toString().ascii().data(),
                         AvailableSize().inline_size.toString().ascii().data(),
                         AvailableSize().block_size.toString().ascii().data());
 }
 
 }  // namespace blink