Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 2616093003: Make CSSParserContext be garbage collected. (Closed)
Patch Set: fix fuzzer compile again Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
index d886266675116cbf3a90e6d768eb49991dae2c1d..4f291e7e4f87f84b9699ba9c70396ca4351f9424 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h
@@ -47,18 +47,18 @@ class CSSPropertyParser {
static bool parseValue(CSSPropertyID,
bool important,
const CSSParserTokenRange&,
- const CSSParserContext&,
+ const CSSParserContext*,
HeapVector<CSSProperty, 256>&,
StyleRule::RuleType);
// Parses a non-shorthand CSS property
static const CSSValue* parseSingleValue(CSSPropertyID,
const CSSParserTokenRange&,
- const CSSParserContext&);
+ const CSSParserContext*);
private:
CSSPropertyParser(const CSSParserTokenRange&,
- const CSSParserContext&,
+ const CSSParserContext*,
HeapVector<CSSProperty, 256>*);
// TODO(timloh): Rename once the CSSParserValue-based parseValue is removed
@@ -67,7 +67,7 @@ class CSSPropertyParser {
const CSSValue* parseSingleValue(CSSPropertyID,
CSSPropertyID = CSSPropertyInvalid);
- bool inQuirksMode() const { return isQuirksModeBehavior(m_context.mode()); }
+ bool inQuirksMode() const { return isQuirksModeBehavior(m_context->mode()); }
bool parseViewportDescriptor(CSSPropertyID propId, bool important);
bool parseFontFaceDescriptor(CSSPropertyID);
@@ -117,7 +117,7 @@ class CSSPropertyParser {
private:
// Inputs:
CSSParserTokenRange m_range;
- const CSSParserContext& m_context;
+ Member<const CSSParserContext> m_context;
// Outputs:
HeapVector<CSSProperty, 256>* m_parsedProperties;
};

Powered by Google App Engine
This is Rietveld 408576698