Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserImpl.h

Issue 2616093003: Make CSSParserContext be garbage collected. (Closed)
Patch Set: comments 1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
index 219ab0dd541d54ac6655d770199319d75627f2f3..4310671f4252d129ea1bef45495ca29fa6e5c2e5 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
+++ b/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h
@@ -41,7 +41,7 @@ class CSSParserImpl {
WTF_MAKE_NONCOPYABLE(CSSParserImpl);
public:
- CSSParserImpl(const CSSParserContext&, StyleSheetContents* = nullptr);
+ CSSParserImpl(const CSSParserContext*, StyleSheetContents* = nullptr);
enum AllowedRulesType {
// As per css-syntax, css-cascade and css-namespaces, @charset rules
@@ -62,26 +62,26 @@ class CSSParserImpl {
CSSPropertyID,
const String&,
bool important,
- const CSSParserContext&);
+ const CSSParserContext*);
static MutableStylePropertySet::SetResult parseVariableValue(
MutableStylePropertySet*,
const AtomicString& propertyName,
const PropertyRegistry*,
const String&,
bool important,
- const CSSParserContext&,
+ const CSSParserContext*,
bool isAnimationTainted);
static ImmutableStylePropertySet* parseInlineStyleDeclaration(const String&,
Element*);
static bool parseDeclarationList(MutableStylePropertySet*,
const String&,
- const CSSParserContext&);
+ const CSSParserContext*);
static StyleRuleBase* parseRule(const String&,
- const CSSParserContext&,
+ const CSSParserContext*,
StyleSheetContents*,
AllowedRulesType);
static void parseStyleSheet(const String&,
- const CSSParserContext&,
+ const CSSParserContext*,
StyleSheetContents*,
bool deferPropertyParsing = false);
static CSSSelectorList parsePageSelector(CSSParserTokenRange,
@@ -94,16 +94,16 @@ class CSSParserImpl {
bool supportsDeclaration(CSSParserTokenRange&);
static void parseDeclarationListForInspector(const String&,
- const CSSParserContext&,
+ const CSSParserContext*,
CSSParserObserver&);
static void parseStyleSheetForInspector(const String&,
- const CSSParserContext&,
+ const CSSParserContext*,
StyleSheetContents*,
CSSParserObserver&);
static StylePropertySet* parseDeclarationListForLazyStyle(
CSSParserTokenRange block,
- const CSSParserContext&);
+ const CSSParserContext*);
private:
enum RuleListType { TopLevelRuleList, RegularRuleList, KeyframesRuleList };
@@ -157,8 +157,8 @@ class CSSParserImpl {
// FIXME: Can we build StylePropertySets directly?
// FIXME: Investigate using a smaller inline buffer
HeapVector<CSSProperty, 256> m_parsedProperties;
- const CSSParserContext& m_context;
+ Member<const CSSParserContext> m_context;
Member<StyleSheetContents> m_styleSheet;
// For the inspector

Powered by Google App Engine
This is Rietveld 408576698