Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp

Issue 2616093003: Make CSSParserContext be garbage collected. (Closed)
Patch Set: comments 1 Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
diff --git a/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp b/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
index e22465a47af3244bd13fecf72073298873e17a02..f226d909799a279b6f20271effa0e9e7e36dfee5 100644
--- a/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
+++ b/third_party/WebKit/Source/core/css/ActiveStyleSheetsTest.cpp
@@ -23,7 +23,7 @@ class ActiveStyleSheetsTest : public ::testing::Test {
protected:
static CSSStyleSheet* createSheet(const String& cssText = String()) {
StyleSheetContents* contents =
- StyleSheetContents::create(CSSParserContext(HTMLStandardMode, nullptr));
+ StyleSheetContents::create(new CSSParserContext(HTMLStandardMode));
haraken 2017/01/12 04:51:13 Blink prefers a factory pattern. Can you replace a
Bret 2017/01/13 02:15:28 Done.
contents->parseString(cssText);
contents->ensureRuleSet(MediaQueryEvaluator(),
RuleHasDocumentSecurityOrigin);

Powered by Google App Engine
This is Rietveld 408576698