third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp - Issue 2616093003: Make CSSParserContext be garbage collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

Issue 2616093003: Make CSSParserContext be garbage collected. (Closed)

Patch Set: fix fuzzer compile Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h ('K') | « third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp ('k') | third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp » ('j') | third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

index f5ff6bd5f6ae5d23b0ef3075ae774e921827dfe9..f2baa8f31d2219e57026a97dc5663bd39521c101 100644

--- a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp

@@ -31,8 +31,8 @@ class SharedStyleFinderTest : public ::testing::Test {

void addSelector(const String& selector) {

StyleRuleBase* newRule =

- CSSParser::parseRule(CSSParserContext(HTMLStandardMode, nullptr),

- nullptr, selector + "{color:pink}");

+ CSSParser::parseRule(new CSSParserContext(HTMLStandardMode), nullptr,

+ selector + "{color:pink}");

m_ruleSet->addStyleRule(static_cast<StyleRule*>(newRule),

RuleHasNoSpecialState);

}