Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h

Issue 2616023004: Remove NoExceptionStateAssertionChecker (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
index 83c10d7959ea43fabc712872c3f9d8bf8ffc8c23..b2b32309a7e7435d72cee9135213bc91c1d31ef4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ExceptionStatePlaceholder.h
@@ -41,36 +41,11 @@ namespace blink {
#define IGNORE_EXCEPTION (::blink::DummyExceptionStateForTesting().returnThis())
Yuki 2017/01/06 06:34:07 IGNORE_EXCEPTION is already defined in ExceptionSt
#if ENABLE(ASSERT)
-
-class CORE_EXPORT NoExceptionStateAssertionChecker final
- : public ExceptionState {
- WTF_MAKE_NONCOPYABLE(NoExceptionStateAssertionChecker);
-
- public:
- NoExceptionStateAssertionChecker(const char* file, int line);
-
- ExceptionState& returnThis() { return *this; }
-
- void throwDOMException(ExceptionCode, const String& message) override;
- void throwRangeError(const String& message) override;
- void throwSecurityError(const String& sanitizedMessage,
- const String& unsanitizedMessage) override;
- void throwTypeError(const String& message) override;
- void rethrowV8Exception(v8::Local<v8::Value>) override;
-
- private:
- const char* m_file;
- const int m_line;
-};
-
#define ASSERT_NO_EXCEPTION \
Yuki 2017/01/06 06:34:07 ASSERT_NO_EXCEPTION is already defined in Exceptio
- (::blink::NoExceptionStateAssertionChecker(__FILE__, __LINE__).returnThis())
-
+ (::blink::NonThrowableExceptionState(__FILE__, __LINE__).returnThis())
#else
-
#define ASSERT_NO_EXCEPTION \
(::blink::DummyExceptionStateForTesting().returnThis())
-
#endif
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698