Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2616023003: [Devtools] Reverse dependency of ResourceTreeModel and NetworkLog (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The Chromium Authors. All rights reserved. 2 * Copyright 2014 The Chromium Authors. All rights reserved.
3 * Use of this source code is governed by a BSD-style license that can be 3 * Use of this source code is governed by a BSD-style license that can be
4 * found in the LICENSE file. 4 * found in the LICENSE file.
5 */ 5 */
6 6
7 /** 7 /**
8 * @unrestricted 8 * @unrestricted
9 */ 9 */
10 SDK.TargetManager = class extends Common.Object { 10 SDK.TargetManager = class extends Common.Object {
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 createTarget(name, capabilitiesMask, connectionFactory, parentTarget) { 164 createTarget(name, capabilitiesMask, connectionFactory, parentTarget) {
165 var target = new SDK.Target(this, name, capabilitiesMask, connectionFactory, parentTarget); 165 var target = new SDK.Target(this, name, capabilitiesMask, connectionFactory, parentTarget);
166 166
167 var logAgent = target.hasLogCapability() ? target.logAgent() : null; 167 var logAgent = target.hasLogCapability() ? target.logAgent() : null;
168 168
169 /** @type {!SDK.ConsoleModel} */ 169 /** @type {!SDK.ConsoleModel} */
170 target.consoleModel = new SDK.ConsoleModel(target, logAgent); 170 target.consoleModel = new SDK.ConsoleModel(target, logAgent);
171 171
172 var networkManager = null; 172 var networkManager = null;
173 var resourceTreeModel = null; 173 var resourceTreeModel = null;
174 if (target.hasNetworkCapability()) 174 if (target.hasNetworkCapability()) {
175 networkManager = new SDK.NetworkManager(target); 175 networkManager = new SDK.NetworkManager(target);
176 if (networkManager && target.hasDOMCapability()) { 176 var networkLog = new SDK.NetworkLog(target, networkManager);
177 resourceTreeModel = 177 if (target.hasDOMCapability()) {
178 new SDK.ResourceTreeModel(target, networkManager, SDK.SecurityOriginMa nager.fromTarget(target)); 178 resourceTreeModel =
179 new SDK.NetworkLog(target, resourceTreeModel, networkManager); 179 new SDK.ResourceTreeModel(target, networkManager, SDK.SecurityOrigin Manager.fromTarget(target), networkLog);
180 }
180 } 181 }
181 182
182 /** @type {!SDK.RuntimeModel} */ 183 /** @type {!SDK.RuntimeModel} */
183 target.runtimeModel = new SDK.RuntimeModel(target); 184 target.runtimeModel = new SDK.RuntimeModel(target);
184 185
185 if (target.hasJSCapability()) 186 if (target.hasJSCapability())
186 new SDK.DebuggerModel(target); 187 new SDK.DebuggerModel(target);
187 188
188 if (resourceTreeModel) { 189 if (resourceTreeModel) {
189 var domModel = new SDK.DOMModel(target); 190 var domModel = new SDK.DOMModel(target);
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 /** 408 /**
408 * @param {!SDK.Target} target 409 * @param {!SDK.Target} target
409 */ 410 */
410 targetRemoved(target) {}, 411 targetRemoved(target) {},
411 }; 412 };
412 413
413 /** 414 /**
414 * @type {!SDK.TargetManager} 415 * @type {!SDK.TargetManager}
415 */ 416 */
416 SDK.targetManager = new SDK.TargetManager(); 417 SDK.targetManager = new SDK.TargetManager();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698