third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp - Issue 2615953003: Rename IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

Issue 2615953003: Rename IGNORE_EXCEPTION to IGNORE_EXCEPTION_FOR_TESTING (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ExceptionState.h ('K') | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

index cea76b1420611e349985b7dd0f94a792ab77d1b1..2e39da63a1baa622881c20b340dd8ff9bfff73cc 100644

--- a/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/SplitElementCommand.cpp

@@ -85,14 +85,14 @@ void SplitElementCommand::doUnapply() {

Node* refChild = m_element2->firstChild();

for (const auto& child : children)

- m_element2->insertBefore(child, refChild, IGNORE_EXCEPTION);

+ m_element2->insertBefore(child, refChild, IGNORE_EXCEPTION_FOR_TESTING);

// Recover the id attribute of the original element.

const AtomicString& id = m_element1->getAttribute(HTMLNames::idAttr);

if (!id.isNull())

m_element2->setAttribute(HTMLNames::idAttr, id);

- m_element1->remove(IGNORE_EXCEPTION);

+ m_element1->remove(IGNORE_EXCEPTION_FOR_TESTING);

}

void SplitElementCommand::doReapply() {