|
Reapply "reflectType() dynamic type arguments support (#26012)"
This was a pull request: 8a8033a4176a2f26e8ed035497631d539dc1ede5
MirrorsUsed doesn't transitively include reflective information. However, it must still be able to create TypeMirrors for types that are used as return- or parameter types.
Initially, the patch checked that TypeMirrors had the correct number of arguments for generic types. This is now disabled.
A better approach would be to know if a class has full reflective information, or not. But this would require much bigger changes to the system.
R=sigmund@google.com
Committed: https://github.com/dart-lang/sdk/commit/2547caab258bec7b8d9742df2cce3fdfc2680786
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+672 lines, -464 lines) |
Patch |
|
M |
pkg/compiler/lib/src/js_backend/backend.dart
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
pkg/compiler/lib/src/mirrors_used.dart
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/lib/mirrors.cc
|
View
|
|
1 chunk |
+64 lines, -0 lines |
0 comments
|
Download
|
|
M |
runtime/lib/mirrors_impl.dart
|
View
|
|
3 chunks |
+14 lines, -1 line |
0 comments
|
Download
|
|
M |
runtime/lib/mirrors_patch.dart
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
runtime/vm/bootstrap_natives.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/js_runtime/lib/js_mirrors.dart
|
View
|
1
|
80 chunks |
+413 lines, -428 lines |
0 comments
|
Download
|
|
M |
sdk/lib/_internal/js_runtime/lib/mirrors_patch.dart
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
sdk/lib/mirrors/mirrors.dart
|
View
|
|
11 chunks |
+33 lines, -28 lines |
0 comments
|
Download
|
|
M |
tests/lib/lib.status
|
View
|
1
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
|
A |
tests/lib/mirrors/mirrors_used_generic_types_test.dart
|
View
|
1
2
|
1 chunk |
+28 lines, -0 lines |
0 comments
|
Download
|
|
A |
tests/lib/mirrors/reflected_type_generics_test.dart
|
View
|
1
|
1 chunk |
+99 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/lib/mirrors/reflected_type_helper.dart
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 7 (4 generated)
|