Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: third_party/WebKit/Source/platform/text/LocaleICU.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/text/LocaleICU.cpp
diff --git a/third_party/WebKit/Source/platform/text/LocaleICU.cpp b/third_party/WebKit/Source/platform/text/LocaleICU.cpp
index 3d630343e21ef892b7d01f1795eb5b57dacbea93..641e5527163128bee197e13debd0e1367d701838 100644
--- a/third_party/WebKit/Source/platform/text/LocaleICU.cpp
+++ b/third_party/WebKit/Source/platform/text/LocaleICU.cpp
@@ -112,18 +112,18 @@ void LocaleICU::initializeLocaleData() {
return;
Vector<String, DecimalSymbolsSize> symbols;
- symbols.append(decimalSymbol(UNUM_ZERO_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_ONE_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_TWO_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_THREE_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_FOUR_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_FIVE_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_SIX_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_SEVEN_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_EIGHT_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_NINE_DIGIT_SYMBOL));
- symbols.append(decimalSymbol(UNUM_DECIMAL_SEPARATOR_SYMBOL));
- symbols.append(decimalSymbol(UNUM_GROUPING_SEPARATOR_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_ZERO_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_ONE_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_TWO_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_THREE_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_FOUR_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_FIVE_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_SIX_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_SEVEN_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_EIGHT_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_NINE_DIGIT_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_DECIMAL_SEPARATOR_SYMBOL));
+ symbols.push_back(decimalSymbol(UNUM_GROUPING_SEPARATOR_SYMBOL));
ASSERT(symbols.size() == DecimalSymbolsSize);
setLocaleData(symbols, decimalTextAttribute(UNUM_POSITIVE_PREFIX),
decimalTextAttribute(UNUM_POSITIVE_SUFFIX),
@@ -217,7 +217,7 @@ std::unique_ptr<Vector<String>> LocaleICU::createLabelVector(
}
if (U_FAILURE(status))
return std::unique_ptr<Vector<String>>();
- labels->append(String::adopt(buffer));
+ labels->push_back(String::adopt(buffer));
}
return labels;
}
@@ -225,13 +225,13 @@ std::unique_ptr<Vector<String>> LocaleICU::createLabelVector(
static std::unique_ptr<Vector<String>> createFallbackWeekDayShortLabels() {
std::unique_ptr<Vector<String>> labels = WTF::makeUnique<Vector<String>>();
labels->reserveCapacity(7);
- labels->append("Sun");
- labels->append("Mon");
- labels->append("Tue");
- labels->append("Wed");
- labels->append("Thu");
- labels->append("Fri");
- labels->append("Sat");
+ labels->push_back("Sun");
+ labels->push_back("Mon");
+ labels->push_back("Tue");
+ labels->push_back("Wed");
+ labels->push_back("Thu");
+ labels->push_back("Fri");
+ labels->push_back("Sat");
return labels;
}
@@ -258,7 +258,7 @@ static std::unique_ptr<Vector<String>> createFallbackMonthLabels() {
std::unique_ptr<Vector<String>> labels = WTF::makeUnique<Vector<String>>();
labels->reserveCapacity(WTF_ARRAY_LENGTH(WTF::monthFullName));
for (unsigned i = 0; i < WTF_ARRAY_LENGTH(WTF::monthFullName); ++i)
- labels->append(WTF::monthFullName[i]);
+ labels->push_back(WTF::monthFullName[i]);
return labels;
}
@@ -294,8 +294,8 @@ bool LocaleICU::isRTL() {
static std::unique_ptr<Vector<String>> createFallbackAMPMLabels() {
std::unique_ptr<Vector<String>> labels = WTF::makeUnique<Vector<String>>();
labels->reserveCapacity(2);
- labels->append("AM");
- labels->append("PM");
+ labels->push_back("AM");
+ labels->push_back("PM");
return labels;
}
@@ -414,7 +414,7 @@ const Vector<String>& LocaleICU::shortMonthLabels() {
}
m_shortMonthLabels.reserveCapacity(WTF_ARRAY_LENGTH(WTF::monthName));
for (unsigned i = 0; i < WTF_ARRAY_LENGTH(WTF::monthName); ++i)
- m_shortMonthLabels.append(WTF::monthName[i]);
+ m_shortMonthLabels.push_back(WTF::monthName[i]);
return m_shortMonthLabels;
}
« no previous file with comments | « third_party/WebKit/Source/platform/text/Hyphenation.cpp ('k') | third_party/WebKit/Source/platform/text/LocaleICUTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698