Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: third_party/WebKit/Source/platform/network/FormDataEncoder.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/FormDataEncoder.cpp
diff --git a/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp
index c0c7e5276834eca00186cdaffff41168690da4a6..d45201e2efdedb19224d4e5e4f07bd505d526851 100644
--- a/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp
+++ b/third_party/WebKit/Source/platform/network/FormDataEncoder.cpp
@@ -35,7 +35,7 @@ namespace blink {
// Helper functions
static inline void append(Vector<char>& buffer, char string) {
- buffer.append(string);
+ buffer.push_back(string);
}
static inline void append(Vector<char>& buffer, const char* string) {
@@ -124,14 +124,14 @@ Vector<char> FormDataEncoder::generateUniqueBoundaryString() {
for (unsigned i = 0; i < 4; ++i) {
uint32_t randomness = cryptographicallyRandomNumber();
- randomBytes.append(alphaNumericEncodingMap[(randomness >> 24) & 0x3F]);
- randomBytes.append(alphaNumericEncodingMap[(randomness >> 16) & 0x3F]);
- randomBytes.append(alphaNumericEncodingMap[(randomness >> 8) & 0x3F]);
- randomBytes.append(alphaNumericEncodingMap[randomness & 0x3F]);
+ randomBytes.push_back(alphaNumericEncodingMap[(randomness >> 24) & 0x3F]);
+ randomBytes.push_back(alphaNumericEncodingMap[(randomness >> 16) & 0x3F]);
+ randomBytes.push_back(alphaNumericEncodingMap[(randomness >> 8) & 0x3F]);
+ randomBytes.push_back(alphaNumericEncodingMap[randomness & 0x3F]);
}
boundary.appendVector(randomBytes);
- boundary.append(
+ boundary.push_back(
0); // Add a 0 at the end so we can use this as a C-style string.
return boundary;
}

Powered by Google App Engine
This is Rietveld 408576698