Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
index 3da4c32e021c074f188e51b78f648f70e3ecdb68..90bcff377d4614c143ff1dfa32faccd5c523a3e8 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
@@ -211,7 +211,7 @@ void GraphicsLayer::addChildInternal(GraphicsLayer* childLayer) {
childLayer->removeFromParent();
childLayer->setParent(this);
- m_children.append(childLayer);
+ m_children.push_back(childLayer);
// Don't call updateChildList here, this function is used in cases where it
// should not be called until all children are processed.
@@ -239,7 +239,7 @@ void GraphicsLayer::addChildBelow(GraphicsLayer* childLayer,
childLayer->setParent(this);
if (!found)
- m_children.append(childLayer);
+ m_children.push_back(childLayer);
updateChildList();
}
@@ -553,7 +553,7 @@ void GraphicsLayer::trackRasterInvalidation(const DisplayItemClient& client,
info.clientDebugName = client.debugName();
info.rect = rect;
info.reason = reason;
- tracking.trackedRasterInvalidations.append(info);
+ tracking.trackedRasterInvalidations.push_back(info);
}
if (RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled()) {
@@ -1156,7 +1156,7 @@ void GraphicsLayer::setPaintingPhase(GraphicsLayerPaintingPhase phase) {
void GraphicsLayer::addLinkHighlight(LinkHighlight* linkHighlight) {
DCHECK(linkHighlight && !m_linkHighlights.contains(linkHighlight));
- m_linkHighlights.append(linkHighlight);
+ m_linkHighlights.push_back(linkHighlight);
linkHighlight->layer()->setLayerClient(this);
updateChildList();
}
@@ -1319,7 +1319,7 @@ void GraphicsLayer::checkPaintUnderInvalidations(const SkPicture& newPicture) {
if (mismatchingPixels < maxMismatchesToReport) {
UnderPaintInvalidation underPaintInvalidation = {layerX, layerY,
oldPixel, newPixel};
- tracking->underPaintInvalidations.append(underPaintInvalidation);
+ tracking->underPaintInvalidations.push_back(underPaintInvalidation);
LOG(ERROR) << debugName()
<< " Uninvalidated old/new pixels mismatch at " << layerX
<< "," << layerY << " old:" << std::hex << oldPixel

Powered by Google App Engine
This is Rietveld 408576698