Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp b/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
index ca6593879d53a38a0c5c45454533404429c01737..8390f58b9562cab9b72e64e95e2f0706cf91666e 100644
--- a/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
+++ b/third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp
@@ -59,7 +59,7 @@ void ICUScriptData::getScripts(UChar32 ch, Vector<UScriptCode>& dst) const {
// to somewhere else in the list.
auto it = std::find(dst.begin() + 1, dst.end(), primaryScript);
if (it == dst.end()) {
- dst.append(primaryScript);
+ dst.push_back(primaryScript);
}
std::swap(*dst.begin(), *it);
return;
@@ -89,7 +89,7 @@ void ICUScriptData::getScripts(UChar32 ch, Vector<UScriptCode>& dst) const {
// Otherwise, use Unicode block as a tie breaker. Comparing
// ScriptCodes as integers is not meaningful because 'old' scripts are
// just sorted in alphabetic order.
- dst.append(dst.at(0));
+ dst.push_back(dst.at(0));
dst.at(0) = primaryScript;
for (size_t i = 2; i < dst.size(); ++i) {
if (dst.at(1) == USCRIPT_LATIN || dst.at(i) < dst.at(1)) {
@@ -132,7 +132,7 @@ ScriptRunIterator::ScriptRunIterator(const UChar* text,
// Priming the m_currentSet with USCRIPT_COMMON here so that the first
// resolution between m_currentSet and m_nextSet in mergeSets() leads to
// chosing the script of the first consumed character.
- m_currentSet.append(USCRIPT_COMMON);
+ m_currentSet.push_back(USCRIPT_COMMON);
U16_NEXT(m_text, m_aheadPos, m_length, m_aheadCharacter);
m_scriptData->getScripts(m_aheadCharacter, m_aheadSet);
}
@@ -194,7 +194,7 @@ void ScriptRunIterator::closeBracket(UChar32 ch) {
// Have a match, use open paren's resolved script.
UScriptCode script = it->script;
m_nextSet.clear();
- m_nextSet.append(script);
+ m_nextSet.push_back(script);
// And pop stack to this point.
int numPopped = std::distance(m_brackets.rbegin(), it);

Powered by Google App Engine
This is Rietveld 408576698