Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: third_party/WebKit/Source/platform/blob/BlobData.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/blob/BlobData.cpp
diff --git a/third_party/WebKit/Source/platform/blob/BlobData.cpp b/third_party/WebKit/Source/platform/blob/BlobData.cpp
index c0c7199c6e2bfce24dfb039663abea02bc6c4359..b295c8817242ea8581938d9997e3c5e19373138f 100644
--- a/third_party/WebKit/Source/platform/blob/BlobData.cpp
+++ b/third_party/WebKit/Source/platform/blob/BlobData.cpp
@@ -82,7 +82,7 @@ std::unique_ptr<BlobData> BlobData::createForFileWithUnknownSize(
const String& path) {
std::unique_ptr<BlobData> data = WTF::wrapUnique(
new BlobData(FileCompositionStatus::SINGLE_UNKNOWN_SIZE_FILE));
- data->m_items.append(BlobDataItem(path));
+ data->m_items.push_back(BlobDataItem(path));
return data;
}
@@ -104,7 +104,7 @@ void BlobData::appendData(PassRefPtr<RawData> data,
long long length) {
CHECK_EQ(m_fileComposition, FileCompositionStatus::NO_UNKNOWN_SIZE_FILES)
<< "Blobs with a unknown-size file cannot have other items.";
- m_items.append(BlobDataItem(std::move(data), offset, length));
+ m_items.push_back(BlobDataItem(std::move(data), offset, length));
}
void BlobData::appendFile(const String& path,
@@ -113,7 +113,8 @@ void BlobData::appendFile(const String& path,
double expectedModificationTime) {
CHECK_EQ(m_fileComposition, FileCompositionStatus::NO_UNKNOWN_SIZE_FILES)
<< "Blobs with a unknown-size file cannot have other items.";
- m_items.append(BlobDataItem(path, offset, length, expectedModificationTime));
+ m_items.push_back(
+ BlobDataItem(path, offset, length, expectedModificationTime));
}
void BlobData::appendBlob(PassRefPtr<BlobDataHandle> dataHandle,
@@ -121,7 +122,7 @@ void BlobData::appendBlob(PassRefPtr<BlobDataHandle> dataHandle,
long long length) {
CHECK_EQ(m_fileComposition, FileCompositionStatus::NO_UNKNOWN_SIZE_FILES)
<< "Blobs with a unknown-size file cannot have other items.";
- m_items.append(BlobDataItem(std::move(dataHandle), offset, length));
+ m_items.push_back(BlobDataItem(std::move(dataHandle), offset, length));
}
void BlobData::appendFileSystemURL(const KURL& url,
@@ -130,7 +131,8 @@ void BlobData::appendFileSystemURL(const KURL& url,
double expectedModificationTime) {
CHECK_EQ(m_fileComposition, FileCompositionStatus::NO_UNKNOWN_SIZE_FILES)
<< "Blobs with a unknown-size file cannot have other items.";
- m_items.append(BlobDataItem(url, offset, length, expectedModificationTime));
+ m_items.push_back(
+ BlobDataItem(url, offset, length, expectedModificationTime));
}
void BlobData::appendText(const String& text,
@@ -154,7 +156,7 @@ void BlobData::appendText(const String& text,
}
if (data)
- m_items.append(BlobDataItem(data.release()));
+ m_items.push_back(BlobDataItem(data.release()));
}
void BlobData::appendBytes(const void* bytes, size_t length) {
@@ -168,7 +170,7 @@ void BlobData::appendBytes(const void* bytes, size_t length) {
RefPtr<RawData> data = RawData::create();
Vector<char>* buffer = data->mutableData();
buffer->append(static_cast<const char*>(bytes), length);
- m_items.append(BlobDataItem(data.release()));
+ m_items.push_back(BlobDataItem(data.release()));
}
long long BlobData::length() const {
« no previous file with comments | « third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp ('k') | third_party/WebKit/Source/platform/exported/WebImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698