Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: third_party/WebKit/Source/platform/WebVectorTest.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/WebVectorTest.cpp
diff --git a/third_party/WebKit/Source/platform/WebVectorTest.cpp b/third_party/WebKit/Source/platform/WebVectorTest.cpp
index ab44d75a1574de56e22997d98f19dfc9e6fd6734..c26d1507a5bdf50df75426981fb92418b78bec71 100644
--- a/third_party/WebKit/Source/platform/WebVectorTest.cpp
+++ b/third_party/WebKit/Source/platform/WebVectorTest.cpp
@@ -13,7 +13,7 @@ namespace blink {
TEST(WebVectorTest, Iterators) {
Vector<int> input;
for (int i = 0; i < 5; ++i)
- input.append(i);
+ input.push_back(i);
WebVector<int> webVector(input);
const WebVector<int>& constWebVector = webVector;
@@ -24,7 +24,7 @@ TEST(WebVectorTest, Iterators) {
// Use begin()/end() iterators directly.
for (WebVector<int>::iterator it = webVector.begin(); it != webVector.end();
++it)
- output.append(*it);
+ output.push_back(*it);
ASSERT_EQ(input.size(), output.size());
for (size_t i = 0; i < input.size(); ++i)
EXPECT_EQ(input[i], output[i]);
@@ -33,7 +33,7 @@ TEST(WebVectorTest, Iterators) {
output.clear();
for (WebVector<int>::const_iterator it = constWebVector.begin();
it != constWebVector.end(); ++it)
- output.append(*it);
+ output.push_back(*it);
ASSERT_EQ(input.size(), output.size());
for (size_t i = 0; i < input.size(); ++i)
EXPECT_EQ(input[i], output[i]);
@@ -41,7 +41,7 @@ TEST(WebVectorTest, Iterators) {
// Use range-based for loop.
output.clear();
for (int x : webVector)
- output.append(x);
+ output.push_back(x);
ASSERT_EQ(input.size(), output.size());
for (size_t i = 0; i < input.size(); ++i)
EXPECT_EQ(input[i], output[i]);
@@ -88,7 +88,7 @@ TEST(WebVectorTest, CreateFromPointer) {
TEST(WebVectorTest, CreateFromWtfVector) {
Vector<int> input;
for (int i = 0; i < 5; ++i)
- input.append(i);
+ input.push_back(i);
WebVector<int> vector(input);
ASSERT_EQ(input.size(), vector.size());

Powered by Google App Engine
This is Rietveld 408576698