Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h

Issue 2615803002: Disallow SharedArrayBuffer in postMessage transfer list (Closed)
Patch Set: remove exceptionState Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
index 48bc1c44ace9d6812c4f4a155894328b2774a663..9ba268b6a2726456234b2686063aa00c5ada83b7 100644
--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.h
@@ -70,7 +70,7 @@ class GC_PLUGIN_IGNORE("https://crbug.com/644725")
// neuter objects in the source context).
// This separation is required by the spec (it prevents neutering from
// happening if there's a failure earlier in serialization).
- void prepareTransfer(Transferables*);
+ void prepareTransfer(Transferables*, ExceptionState&);
void finalizeTransfer(ExceptionState&);
// Shared between File and FileList logic; does not write a leading tag.
@@ -80,6 +80,9 @@ class GC_PLUGIN_IGNORE("https://crbug.com/644725")
void ThrowDataCloneError(v8::Local<v8::String> message) override;
v8::Maybe<bool> WriteHostObject(v8::Isolate*,
v8::Local<v8::Object> message) override;
+ v8::Maybe<uint32_t> GetSharedArrayBufferId(
+ v8::Isolate*,
+ v8::Local<v8::SharedArrayBuffer>) override;
void* ReallocateBufferMemory(void* oldBuffer,
size_t,
@@ -92,6 +95,7 @@ class GC_PLUGIN_IGNORE("https://crbug.com/644725")
const Transferables* m_transferables = nullptr;
const ExceptionState* m_exceptionState = nullptr;
WebBlobInfoArray* m_blobInfoArray = nullptr;
+ ArrayBufferArray m_sharedArrayBuffers;
#if DCHECK_IS_ON()
bool m_serializeInvoked = false;

Powered by Google App Engine
This is Rietveld 408576698