arc: Fix situation when ARC cannot be disabled safely.

chrome/browser/chromeos/arc/arc_session_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
 
 #include <utility>
 
 #include "ash/common/shelf/shelf_delegate.h"
 #include "ash/common/wm_shell.h"
@@ skipping 264 matching lines @@
   // Restart ARC anyway. Let the enterprise reporting instance decide whether
   // the ARC user data wipe is still required or not.
   reenable_arc_ = false;
   VLOG(1) << "Reenable ARC";
   EnableArc();
 }
 
 void ArcSessionManager::OnProvisioningFinished(ProvisioningResult result) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
+  // If the Mojo message to notify finishing the provisioning is already sent
+  // from the container, it will be processed even after requesting to stop the
+  // container. Ignore all |result|s arriving while ARC is disabled, in order to
+  // avoid popping up an error message triggered below. This code intentionally
+  // does not support the case of reenabling.
+  if (!IsArcEnabled()) {
+    LOG(WARNING) << "Provisioning result received after Arc was disabled. "
+                 << "Ignoring result " << static_cast<int>(result) << ".";
+    return;
+  }
+
   // Due asynchronous nature of stopping the ARC instance,
   // OnProvisioningFinished may arrive after setting the |State::STOPPED| state
   // and |State::Active| is not guaranteed to be set here.
   // prefs::kArcDataRemoveRequested also can be active for now.
 
   if (provisioning_reported_) {
     // We don't expect ProvisioningResult::SUCCESS is reported twice or reported
     // after an error.
     DCHECK_NE(result, ProvisioningResult::SUCCESS);
     // TODO (khmel): Consider changing LOG to NOTREACHED once we guaranty that
     // no double message can happen in production.
-    LOG(WARNING) << " Provisioning result was already reported. Ignoring "
-                 << " additional result " << static_cast<int>(result) << ".";
+    LOG(WARNING) << "Provisioning result was already reported. Ignoring "
+                 << "additional result " << static_cast<int>(result) << ".";
     return;
   }
   provisioning_reported_ = true;
 
   if (result == ProvisioningResult::CHROME_SERVER_COMMUNICATION_ERROR) {
     if (IsArcKioskMode()) {
       VLOG(1) << "Robot account auth code fetching error";
       // Log out the user. All the cleanup will be done in Shutdown() method.
       // The callback is not called because auth code is empty.
       attempt_user_exit_callback_.Run();
@@ skipping 678 matching lines @@
       return os << "ACTIVE";
   }
 
   // Some compiler reports an error even if all values of an enum-class are
   // covered indivisually in a switch statement.
   NOTREACHED();
   return os;
 }
 
 }  // namespace arc