third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp - Issue 2615773003: Replace LayerImpl::sorting_context_id with transform reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

Issue 2615773003: Replace LayerImpl::sorting_context_id with transform reference. (Closed)

Patch Set: Update tests. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/layers/solid_color_layer_impl_unittest.cc ('K') | « third_party/WebKit/Source/platform/graphics/CompositorMutableStateTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

index f43b2bb58766fa1c7f8bed9a025e9568fc3f028a..a9c5296368d5b6805b0ec6ff884a69c85ab2ed97 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp

@@ -1211,12 +1211,6 @@ void PaintArtifactCompositor::update(

layer->SetEffectTreeIndex(effectId);

layer->SetScrollTreeIndex(scrollId);

- // TODO(jbroman): This probably shouldn't be necessary, but it is still

- // queried by RenderSurfaceImpl.

- layer->Set3dSortingContextId(layerTree->property_trees()

- ->transform_tree.Node(transformId)

- ->sorting_context_id);

layer->SetShouldCheckBackfaceVisibility(pendingLayer.backfaceHidden);

if (m_extraDataForTestingEnabled)