Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: components/variations/study_filtering.cc

Issue 2615763002: Revert of Supporting study definitions without default groups and end_date filtering. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/variations/study_filtering.h ('k') | components/variations/study_filtering_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/variations/study_filtering.cc
diff --git a/components/variations/study_filtering.cc b/components/variations/study_filtering.cc
index 510925132e1b1be266624727f4d7e9572862b89f..159b544f4e7d388e0fc3c49d251a82e8381af48a 100644
--- a/components/variations/study_filtering.cc
+++ b/components/variations/study_filtering.cc
@@ -143,16 +143,6 @@
return true;
}
-bool CheckStudyEndDate(const Study_Filter& filter,
- const base::Time& date_time) {
- if (filter.has_end_date()) {
- const base::Time end_date = ConvertStudyDateToBaseTime(filter.end_date());
- return end_date >= date_time;
- }
-
- return true;
-}
-
bool CheckStudyVersion(const Study_Filter& filter,
const base::Version& version) {
if (filter.has_min_version()) {
@@ -232,11 +222,6 @@
if (!CheckStudyStartDate(study.filter(), reference_date)) {
DVLOG(1) << "Filtered out study " << study.name() <<
" due to start date.";
- return false;
- }
-
- if (!CheckStudyEndDate(study.filter(), reference_date)) {
- DVLOG(1) << "Filtered out study " << study.name() << " due to end date.";
return false;
}
« no previous file with comments | « components/variations/study_filtering.h ('k') | components/variations/study_filtering_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698