Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: ios/chrome/today_extension/today_metrics_logger.mm

Issue 2615753002: Remove time ticks metrics and MetricServiceClient::OnLogUploadComplete (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/today_extension/today_metrics_logger.mm
diff --git a/ios/chrome/today_extension/today_metrics_logger.mm b/ios/chrome/today_extension/today_metrics_logger.mm
index e48119bf3dbce939809a199d8fcd5494fbca7d93..08093ddc23ba699c047b11192a0ffc1bb13d4351 100644
--- a/ios/chrome/today_extension/today_metrics_logger.mm
+++ b/ios/chrome/today_extension/today_metrics_logger.mm
@@ -62,7 +62,6 @@ class TodayMetricsServiceClient : public metrics::MetricsServiceClient {
bool GetBrand(std::string* brand_code) override;
metrics::SystemProfileProto::Channel GetChannel() override;
std::string GetVersionString() override;
- void OnLogUploadComplete() override;
void InitializeSystemProfileMetrics(
const base::Closure& done_callback) override;
void CollectFinalMetricsForLog(const base::Closure& done_callback) override;
@@ -135,10 +134,6 @@ std::string TodayMetricsServiceClient::GetVersionString() {
return metrics::GetVersionString();
}
-void TodayMetricsServiceClient::OnLogUploadComplete() {
- NOTREACHED();
-}
-
void TodayMetricsServiceClient::InitializeSystemProfileMetrics(
const base::Closure& done_callback) {
NOTREACHED();
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698