cros: Fix clusterfuzz crash when spawning app list very early in startup

ash/app_list/app_list_presenter_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/app_list/app_list_presenter_delegate.h"
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/ash_switches.h"
 #include "ash/common/shelf/app_list_button.h"
 #include "ash/common/shelf/shelf_layout_manager.h"
@@ skipping 17 matching lines @@
 #include "ui/app_list/presenter/app_list_view_delegate_factory.h"
 #include "ui/app_list/views/app_list_view.h"
 #include "ui/aura/window.h"
 #include "ui/events/event.h"
 #include "ui/keyboard/keyboard_controller.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
 namespace {
 
-// Gets the point at the center of the display that a particular view is on.
+// Gets the point at the center of the display containing the given |window|.
 // This calculation excludes the virtual keyboard area. If the height of the
 // display area is less than |minimum_height|, its bottom will be extended to
 // that height (so that the app list never starts above the top of the screen).
-gfx::Point GetCenterOfDisplayForView(views::View* view, int minimum_height) {
-  WmWindow* window = WmLookup::Get()->GetWindowForWidget(view->GetWidget());
+gfx::Point GetCenterOfDisplayForWindow(WmWindow* window, int minimum_height) {
+  DCHECK(window);
   gfx::Rect bounds = wm::GetDisplayBoundsWithShelf(window);
   bounds = window->GetRootWindow()->ConvertRectToScreen(bounds);
 
   // If the virtual keyboard is active, subtract it from the display bounds, so
   // that the app list is centered in the non-keyboard area of the display.
   // (Note that work_area excludes the keyboard, but it doesn't get updated
   // until after this function is called.)
   keyboard::KeyboardController* keyboard_controller =
       keyboard::KeyboardController::GetInstance();
   if (keyboard_controller && keyboard_controller->keyboard_visible())
@@ skipping 48 matching lines @@
                                     int current_apps_page) {
   // App list needs to know the new shelf layout in order to calculate its
   // UI layout when AppListView visibility changes.
   ash::Shell::GetPrimaryRootWindowController()
       ->GetShelfLayoutManager()
       ->UpdateAutoHideState();
   view_ = view;
   aura::Window* root_window = Shell::GetInstance()
                                   ->window_tree_host_manager()
                                   ->GetRootWindowForDisplayId(display_id);
+  WmWindow* wm_root_window = WmWindowAura::Get(root_window);
   aura::Window* container = GetRootWindowController(root_window)
                                 ->GetContainer(kShellWindowId_AppListContainer);
-  WmShelf* shelf = WmShelf::ForWindow(WmWindowAura::Get(container));
-  AppListButton* applist_button = shelf->shelf_widget()->GetAppListButton();
   bool is_fullscreen = IsFullscreenAppListEnabled() &&
                        WmShell::Get()
                            ->maximize_mode_controller()
                            ->IsMaximizeModeWindowManagerEnabled();
   if (is_fullscreen) {
     view->InitAsFramelessWindow(
         container, current_apps_page,
         ScreenUtil::GetDisplayWorkAreaBoundsInParent(container));
   } else {
     view->InitAsBubble(container, current_apps_page);
-    // The app list is centered over the display of the app list button that was
-    // pressed (if triggered via keyboard, this is the display with the
-    // currently focused window).
-    view->SetAnchorPoint(GetCenterOfDisplayForView(
-        applist_button, GetMinimumBoundsHeightForAppList(view)));
+    // The app list is centered over the display.
+    view->SetAnchorPoint(GetCenterOfDisplayForWindow(
+        wm_root_window, GetMinimumBoundsHeightForAppList(view)));
   }
 
   keyboard::KeyboardController* keyboard_controller =
       keyboard::KeyboardController::GetInstance();
   if (keyboard_controller)
     keyboard_controller->AddObserver(this);
   Shell::GetInstance()->AddPreTargetHandler(this);
-  WmWindow* window = WmShell::Get()->GetRootWindowForDisplayId(display_id);
-  window->GetRootWindowController()->GetShelf()->AddObserver(this);
+  WmShelf* shelf = WmShelf::ForWindow(wm_root_window);
+  shelf->AddObserver(this);
 
   // By setting us as DnD recipient, the app list knows that we can
   // handle items.
   view->SetDragAndDropHostOfCurrentAppList(
       shelf->shelf_widget()->GetDragAndDropHostForAppList());
 }
 
 void AppListPresenterDelegate::OnShown(int64_t display_id) {
   is_visible_ = true;
   // Update applist button status when app list visibility is changed.
   WmWindow* root_window = WmShell::Get()->GetRootWindowForDisplayId(display_id);
-  WmShelf::ForWindow(root_window)
-      ->shelf_widget()
-      ->GetAppListButton()
-      ->OnAppListShown();
+  AppListButton* app_list_button =
+      WmShelf::ForWindow(root_window)->shelf_widget()->GetAppListButton();
+  if (app_list_button)
+    app_list_button->OnAppListShown();
 }
 
 void AppListPresenterDelegate::OnDismissed() {
   DCHECK(is_visible_);
   DCHECK(view_);
 
   is_visible_ = false;
 
   // Update applist button status when app list visibility is changed.
-  WmShelf* shelf = WmShelf::ForWindow(
-      WmLookup::Get()->GetWindowForWidget(view_->GetWidget()));
-  shelf->shelf_widget()->GetAppListButton()->OnAppListDismissed();
+  WmWindow* window = WmLookup::Get()->GetWindowForWidget(view_->GetWidget());
+  AppListButton* app_list_button =
+      WmShelf::ForWindow(window)->shelf_widget()->GetAppListButton();
+  if (app_list_button)
+    app_list_button->OnAppListDismissed();
 }
 
 void AppListPresenterDelegate::UpdateBounds() {
   if (!view_ || !is_visible_)
     return;
 
   view_->UpdateBounds();
-  view_->SetAnchorPoint(GetCenterOfDisplayForView(
-      view_, GetMinimumBoundsHeightForAppList(view_)));
+  view_->SetAnchorPoint(GetCenterOfDisplayForWindow(
+      WmLookup::Get()->GetWindowForWidget(view_->GetWidget()),
+      GetMinimumBoundsHeightForAppList(view_)));
 }
 
 gfx::Vector2d AppListPresenterDelegate::GetVisibilityAnimationOffset(
     aura::Window* root_window) {
   DCHECK(Shell::HasInstance());
 
   // App list needs to know the new shelf layout in order to calculate its
   // UI layout when AppListView visibility changes.
   WmShelf* shelf = WmShelf::ForWindow(WmWindowAura::Get(root_window));
   shelf->UpdateAutoHideState();
@@ skipping 91 matching lines @@
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // AppListPresenterDelegate, WmShelfObserver implementation:
 
 void AppListPresenterDelegate::OnShelfIconPositionsChanged() {
   UpdateBounds();
 }
 
 }  // namespace ash