Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: google_apis/gcm/engine/checkin_request.h

Issue 261573002: Add checkin activity recording to gcm recorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing jian's comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | google_apis/gcm/engine/checkin_request.cc » ('j') | google_apis/gcm/engine/checkin_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/gcm/engine/checkin_request.h
diff --git a/google_apis/gcm/engine/checkin_request.h b/google_apis/gcm/engine/checkin_request.h
index 5ae8dd33a0425099e06fc6a5460ee9b8a7bf60ee..1b81b80ca0ace8d033b4a58570cec34e24c61fe8 100644
--- a/google_apis/gcm/engine/checkin_request.h
+++ b/google_apis/gcm/engine/checkin_request.h
@@ -23,6 +23,8 @@ class URLRequestContextGetter;
namespace gcm {
+class GCMStatsRecorder;
+
// Enables making check-in requests with the GCM infrastructure. When called
// with android_id and security_token both set to 0 it is an initial check-in
// used to obtain credentials. These should be persisted and used for subsequent
@@ -58,7 +60,8 @@ class GCM_EXPORT CheckinRequest : public net::URLFetcherDelegate {
CheckinRequest(const RequestInfo& request_info,
const net::BackoffEntry::Policy& backoff_policy,
const CheckinRequestCallback& callback,
- net::URLRequestContextGetter* request_context_getter);
+ net::URLRequestContextGetter* request_context_getter,
+ GCMStatsRecorder* recorder);
virtual ~CheckinRequest();
void Start();
@@ -78,6 +81,9 @@ class GCM_EXPORT CheckinRequest : public net::URLFetcherDelegate {
scoped_ptr<net::URLFetcher> url_fetcher_;
const RequestInfo request_info_;
+ // Recorder that records GCM activities for debugging purpose. Not owned.
+ GCMStatsRecorder* recorder_;
+
base::WeakPtrFactory<CheckinRequest> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(CheckinRequest);
« no previous file with comments | « no previous file | google_apis/gcm/engine/checkin_request.cc » ('j') | google_apis/gcm/engine/checkin_request.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698