Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2615673002: Make RandomAccessFile.writeFrom use the correct starting offset (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make RandomAccessFile.writeFrom use the correct starting offset fixes #28174 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5c8510bca535c295ae785e8c28682dedcc3a2274

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M runtime/bin/file.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 11 months ago (2017-01-04 17:19:21 UTC) #2
Cutch
lgtm
3 years, 11 months ago (2017-01-04 17:26:55 UTC) #3
zra
3 years, 11 months ago (2017-01-04 17:33:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5c8510bca535c295ae785e8c28682dedcc3a2274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698