Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2615623002: Revert "Reduce use of Element in optimize.dart" (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Reduce use of Element in optimize.dart" This reverts commit 52158e2ad61d614dc1356a38924af541ddaf4d89. Committed: https://github.com/dart-lang/sdk/commit/a7bd904ecc1bf109d79b1a0f7deb731bf38c91c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -119 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 18 chunks +31 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 26 chunks +58 lines, -65 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
TBR
3 years, 11 months ago (2017-01-04 13:27:48 UTC) #2
kasperl
LGTM.
3 years, 11 months ago (2017-01-04 13:28:28 UTC) #3
Johnni Winther
3 years, 11 months ago (2017-01-04 13:28:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7bd904ecc1bf109d79b1a0f7deb731bf38c91c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698