Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/animation/ink_drop_highlight_unittest.cc

Issue 2615613003: Fix double ripple on activated flood fill ripple (Closed)
Patch Set: Used AssertionResult Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/animation/flood_fill_ink_drop_ripple_unittest.cc ('k') | ui/views/animation/ink_drop_ripple.cc » ('j') | ui/views/animation/test/test_ink_drop_animation_observer_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/animation/ink_drop_highlight_unittest.cc
diff --git a/ui/views/animation/ink_drop_highlight_unittest.cc b/ui/views/animation/ink_drop_highlight_unittest.cc
index fa5cc88058660d7bbdd3d0568ac5ccb41001bb4c..fa983daff613131055165ce98e2a953bcee30e7a 100644
--- a/ui/views/animation/ink_drop_highlight_unittest.cc
+++ b/ui/views/animation/ink_drop_highlight_unittest.cc
@@ -56,7 +56,10 @@ InkDropHighlightTest::InkDropHighlightTest() {
gfx::Size(10, 10), 3, gfx::PointF(), SK_ColorBLACK));
}
-InkDropHighlightTest::~InkDropHighlightTest() {}
+InkDropHighlightTest::~InkDropHighlightTest() {
+ // Destory highlight to make sure it is destroyed before the observer.
+ DestroyHighlight();
+}
void InkDropHighlightTest::InitHighlight(
std::unique_ptr<InkDropHighlight> new_highlight) {
« no previous file with comments | « ui/views/animation/flood_fill_ink_drop_ripple_unittest.cc ('k') | ui/views/animation/ink_drop_ripple.cc » ('j') | ui/views/animation/test/test_ink_drop_animation_observer_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698