Fix double ripple on activated flood fill ripple

ui/views/animation/flood_fill_ink_drop_ripple.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/animation/flood_fill_ink_drop_ripple.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkColor.h"
@@ skipping 242 matching lines @@
       break;
     }
     case InkDropState::ALTERNATE_ACTION_TRIGGERED:
       DCHECK(old_ink_drop_state == InkDropState::ALTERNATE_ACTION_PENDING);
       AnimateToOpacity(kHiddenOpacity, GetAnimationDuration(
                                            ALTERNATE_ACTION_TRIGGERED_FADE_OUT),
                        ui::LayerAnimator::ENQUEUE_NEW_ANIMATION,
                        gfx::Tween::EASE_IN_OUT, animation_observer);
       break;
     case InkDropState::ACTIVATED: {
+      if (old_ink_drop_state == InkDropState::ACTION_PENDING) {

[bruthig, 2017/01/04 22:52:07]

I believe this will cause the ACTIVATED |animation_observer| to be notified
before the ACTION_PENDING |animation_observer| which is not desirable.  The
observers, namely InkDropRipple, expects the notifications to come in the same
order that the animations were triggered in.

You could try using a Pause LayerAnimationElement on the opacity and transform
properties that you can enqueue and attach the |animation_observer| to.

[mohsen, 2017/01/05 20:14:37]

Right. Done.

+        // The final state of pending animation is the same as the final state
+        // of activated animation. Nothing more to do here.
+        break;
+      }
       AnimateToOpacity(visible_opacity_,
                        GetAnimationDuration(ACTIVATED_FADE_IN),
                        ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET,
                        gfx::Tween::EASE_IN, animation_observer);
       AnimateToTransform(GetMaxSizeTargetTransform(),
                          GetAnimationDuration(ACTIVATED_TRANSFORM),
                          ui::LayerAnimator::IMMEDIATELY_ANIMATE_TO_NEW_TARGET,
                          gfx::Tween::EASE_IN_OUT, animation_observer);
       break;
     }
@@ skipping 95 matching lines @@
       (bounds.bottom_right() - point).Length();
 
   float largest_distance =
       std::max(distance_to_top_left, distance_to_top_right);
   largest_distance = std::max(largest_distance, distance_to_bottom_left);
   largest_distance = std::max(largest_distance, distance_to_bottom_right);
   return largest_distance;
 }
 
 }  // namespace views