Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2615593002: The async/timer_regress22626_test test looks flaky by design. (Closed)

Created:
3 years, 11 months ago by kasperl
Modified:
3 years, 11 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

The async/timer_regress22626_test test looks flaky by design. Expanding the MIPS-specific flaky marker in the status file to cover all architectures after seeing this on debug-x64 too. See https://github.com/dart-lang/sdk/issues/28254 and the older https://github.com/dart-lang/sdk/issues/22626. R=whesse@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a6135a0c641df7cb599f4e1d49d3a62798fb0b24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tests/lib/lib.status View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kasperl
3 years, 11 months ago (2017-01-04 08:16:01 UTC) #1
kasperl
TBR'ed.
3 years, 11 months ago (2017-01-04 10:35:59 UTC) #2
kasperl
Committed patchset #1 (id:1) manually as a6135a0c641df7cb599f4e1d49d3a62798fb0b24 (presubmit successful).
3 years, 11 months ago (2017-01-04 10:36:35 UTC) #4
Bill Hesse
3 years, 11 months ago (2017-01-04 11:55:20 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698