Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2615533007: Ensure Zone returns correctly aligned pointers for allocations with

Created:
3 years, 11 months ago by Chris Coulson
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure Zone returns correctly aligned pointers for allocations with sizes that are a multiple of 8 bytes on 32-bit platforms. On 32-bit platforms, Zone is meant to return 8-byte aligned pointers for allocations with sizes that are a multiple of 8 bytes. However, this was not guaranteed for allocations that required the size of the Zone to be expanded. In this case, Zone could sometimes return pointers with 4-byte alignment. BUG=v8:5668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/zone/zone.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Chris Coulson
3 years, 11 months ago (2017-01-06 17:27:07 UTC) #2
jochen (gone - plz use gerrit)
instead of adding this runtime correction of the alignment, why not just change kAlignment on ...
3 years, 10 months ago (2017-01-31 15:07:44 UTC) #4
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-01-31 15:15:03 UTC) #5
btw, your account appears to not be part of the CCLA from Canonical. Can you
please work internally with whoever manages the license agreement to get
yourself added, so we can accept contributions?

Once that's done, you should also add yourself to AUTHORS

Powered by Google App Engine
This is Rietveld 408576698