Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: ui/gfx/canvas.cc

Issue 2615493003: use SkSurface behind gfx::Canvas (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gfx/canvas.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/gfx/canvas.h" 5 #include "ui/gfx/canvas.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "third_party/skia/include/core/SkBitmap.h" 12 #include "third_party/skia/include/core/SkBitmap.h"
13 #include "third_party/skia/include/core/SkPath.h" 13 #include "third_party/skia/include/core/SkPath.h"
14 #include "third_party/skia/include/core/SkRefCnt.h" 14 #include "third_party/skia/include/core/SkRefCnt.h"
15 #include "third_party/skia/include/core/SkSurface.h"
15 #include "third_party/skia/include/effects/SkGradientShader.h" 16 #include "third_party/skia/include/effects/SkGradientShader.h"
16 #include "ui/gfx/font_list.h" 17 #include "ui/gfx/font_list.h"
17 #include "ui/gfx/geometry/insets_f.h" 18 #include "ui/gfx/geometry/insets_f.h"
18 #include "ui/gfx/geometry/rect.h" 19 #include "ui/gfx/geometry/rect.h"
19 #include "ui/gfx/geometry/rect_conversions.h" 20 #include "ui/gfx/geometry/rect_conversions.h"
20 #include "ui/gfx/geometry/rect_f.h" 21 #include "ui/gfx/geometry/rect_f.h"
21 #include "ui/gfx/geometry/safe_integer_conversions.h" 22 #include "ui/gfx/geometry/safe_integer_conversions.h"
22 #include "ui/gfx/geometry/size_conversions.h" 23 #include "ui/gfx/geometry/size_conversions.h"
23 #include "ui/gfx/scoped_canvas.h" 24 #include "ui/gfx/scoped_canvas.h"
24 #include "ui/gfx/skia_util.h" 25 #include "ui/gfx/skia_util.h"
25 #include "ui/gfx/transform.h" 26 #include "ui/gfx/transform.h"
26 27
27 namespace gfx { 28 namespace gfx {
28 29
30 namespace {
31
32 sk_sp<SkSurface> CreateSurface(const Size& size, bool is_opaque) {
33 // SkSurface cannot be zero-sized, but clients of Canvas sometimes request
34 // that (and then later resize).
35 int width = std::max(size.width(), 1);
36 int height = std::max(size.height(), 1);
37 SkAlphaType alpha = is_opaque ? kOpaque_SkAlphaType : kPremul_SkAlphaType;
38 SkImageInfo info = SkImageInfo::MakeN32(width, height, alpha);
39 return SkSurface::MakeRaster(info);
40 }
41
42 } // namespace
43
29 Canvas::Canvas(const Size& size, float image_scale, bool is_opaque) 44 Canvas::Canvas(const Size& size, float image_scale, bool is_opaque)
30 : image_scale_(image_scale) { 45 : image_scale_(image_scale) {
31 Size pixel_size = ScaleToCeiledSize(size, image_scale); 46 Size pixel_size = ScaleToCeiledSize(size, image_scale);
32 canvas_owner_ = skia::CreatePlatformCanvas(pixel_size.width(), 47 surface_ = CreateSurface(pixel_size, is_opaque);
33 pixel_size.height(), is_opaque); 48 canvas_ = surface_->getCanvas();
34 canvas_ = canvas_owner_.get();
35 49
36 #if !defined(USE_CAIRO) 50 #if !defined(USE_CAIRO)
37 // skia::PlatformCanvas instances are initialized to 0 by Cairo, but 51 // skia::PlatformCanvas instances are initialized to 0 by Cairo, but
38 // uninitialized on other platforms. 52 // uninitialized on other platforms.
39 if (!is_opaque) 53 if (!is_opaque)
40 canvas_->clear(SkColorSetARGB(0, 0, 0, 0)); 54 canvas_->clear(SkColorSetARGB(0, 0, 0, 0));
41 #endif 55 #endif
42 56
43 SkScalar scale_scalar = SkFloatToScalar(image_scale); 57 SkScalar scale_scalar = SkFloatToScalar(image_scale);
44 canvas_->scale(scale_scalar, scale_scalar); 58 canvas_->scale(scale_scalar, scale_scalar);
45 } 59 }
46 60
47 Canvas::Canvas() 61 Canvas::Canvas()
48 : image_scale_(1.f), 62 : image_scale_(1.f),
49 canvas_owner_(skia::CreatePlatformCanvas(0, 0, false)), 63 surface_(CreateSurface({0, 0}, false)),
50 canvas_(canvas_owner_.get()) {} 64 canvas_(surface_->getCanvas()) {}
51 65
52 Canvas::Canvas(SkCanvas* canvas, float image_scale) 66 Canvas::Canvas(SkCanvas* canvas, float image_scale)
53 : image_scale_(image_scale), canvas_(canvas) { 67 : image_scale_(image_scale), canvas_(canvas) {
54 DCHECK(canvas_); 68 DCHECK(canvas_);
55 } 69 }
56 70
57 Canvas::~Canvas() { 71 Canvas::~Canvas() {
58 } 72 }
59 73
60 void Canvas::RecreateBackingCanvas(const Size& size, 74 void Canvas::RecreateBackingCanvas(const Size& size,
61 float image_scale, 75 float image_scale,
62 bool is_opaque) { 76 bool is_opaque) {
63 image_scale_ = image_scale; 77 image_scale_ = image_scale;
64 Size pixel_size = ScaleToFlooredSize(size, image_scale); 78 Size pixel_size = ScaleToFlooredSize(size, image_scale);
65 canvas_owner_ = skia::CreatePlatformCanvas(pixel_size.width(), 79 surface_ = CreateSurface(pixel_size, is_opaque);
66 pixel_size.height(), is_opaque); 80 canvas_ = surface_->getCanvas();
67 canvas_ = canvas_owner_.get();
68 81
69 SkScalar scale_scalar = SkFloatToScalar(image_scale); 82 SkScalar scale_scalar = SkFloatToScalar(image_scale);
70 canvas_->scale(scale_scalar, scale_scalar); 83 canvas_->scale(scale_scalar, scale_scalar);
71 } 84 }
72 85
73 // static 86 // static
74 void Canvas::SizeStringInt(const base::string16& text, 87 void Canvas::SizeStringInt(const base::string16& text,
75 const FontList& font_list, 88 const FontList& font_list,
76 int* width, 89 int* width,
77 int* height, 90 int* height,
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
579 p.setFilterQuality(filter ? kLow_SkFilterQuality : kNone_SkFilterQuality); 592 p.setFilterQuality(filter ? kLow_SkFilterQuality : kNone_SkFilterQuality);
580 p.setShader(CreateImageRepShaderForScale( 593 p.setShader(CreateImageRepShaderForScale(
581 image_rep, SkShader::kRepeat_TileMode, shader_scale, 594 image_rep, SkShader::kRepeat_TileMode, shader_scale,
582 remove_image_scale ? image_rep.scale() : 1.f)); 595 remove_image_scale ? image_rep.scale() : 1.f));
583 596
584 // The rect will be filled by the bitmap. 597 // The rect will be filled by the bitmap.
585 canvas_->drawRect(dest_rect, p); 598 canvas_->drawRect(dest_rect, p);
586 } 599 }
587 600
588 } // namespace gfx 601 } // namespace gfx
OLDNEW
« no previous file with comments | « ui/gfx/canvas.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698