Signal an error for File.length on a directory

Signal an error for File.length on a directory

fixes #28172

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/128313ec3c020a56aec552e11e4d8f1d55b295fe

[zra, 2017-01-03 21:44:12]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2017-01-03 22:36:08]

LGTM.

As discussed offline I was wondering if we needed to be more strict and returned
the length only for regular files but looks like there is a broader implication
of that with respect to dart:io (e.g: directory listing returns non regular
files also as type File). Need to discuss this with the library team.

[zra, 2017-01-03 23:05:43]

On 2017/01/03 22:36:08, siva wrote:
> LGTM.
> 
> As discussed offline I was wondering if we needed to be more strict and
returned
> the length only for regular files but looks like there is a broader
implication
> of that with respect to dart:io (e.g: directory listing returns non regular
> files also as type File). Need to discuss this with the library team.

Acknowledged. I think we should consider being less strict, as the directory
lister is, more consistently with all the calls on platforms that have
non-regular files, like pipes, etc..

[zra, 2017-01-03 23:06:28]

Description was changed from

==========
Signal an error for File.length on a directory

fixes #28172
==========

to

==========
Signal an error for File.length on a directory

fixes #28172

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/128313ec3c020a56aec552e11e4d8f1d55b295fe
==========

[zra, 2017-01-03 23:06:29]

Committed patchset #2 (id:20001) manually as
128313ec3c020a56aec552e11e4d8f1d55b295fe (presubmit successful).